[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
kern/40969: IPSEC sessions no longer establish (or send any traffic)
>Synopsis: IPSEC sessions no longer establish (or send any traffic)
>Arrival-Date: Fri Mar 06 01:15:01 +0000 2009
>Originator: Geoff C. Wing
>Release: NetBSD 5.99.7
System: NetBSD g.primenet.com.au 5.99.7 NetBSD 5.99.7 (G) #0: Tue Mar 3
12:19:02 EST 2009
IPSEC sessions (esp tunnel in my case) no longer establish
themselves. This is due to sys/netkey/key.c:1.164
date: 2009/01/28 19:06:03; author: skd; state: Exp; lines: +4 -4
These comparison functions return 0 on match. Fix sense of test.
For the two functions - key_cmpsaidx_withmode() and
key_cmpsaidx_exactly() - which had return code comparisons
changed there are comments above each:
* 1 : equal
* 0 : not equal
which clearly indicate that they return 1 on match, not 0.
This wrong change was also made to src/sys/netipsec/key.c in
the same commit but it was subsequently reverted.
Use it. Code inspection.
Main Index |
Thread Index |