Re: kern/40947: Thinkpad panics during shutdown

["Jared D. McNeill" <jmcneill%invisible.ca@localhost>]

The following reply was made to PR kern/40947; it has been noted by GNATS.

From: "Jared D. McNeill" <jmcneill%invisible.ca@localhost>
To: Hauke Fath <hf%spg.tu-darmstadt.de@localhost>
Cc: gnats-bugs%NetBSD.org@localhost
Subject: Re: kern/40947: Thinkpad panics during shutdown
Date: Wed, 04 Mar 2009 06:23:59 -0500

 This is a multi-part message in MIME format.
 --------------020906010007080108090401
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Hauke Fath wrote:
 > Jared D. McNeill wrote:
 >> elink3.c should be adapted to use the new pmf instead of 
 >> shutdownhooks. Can you please try the attached patch?
 > 
 > Thanks. Stack trace looks a little different, but same panic. I'll 
 > enclose the full dmesg.
 
 > epshutdown(c6c7b6a4,0,1,1,c6c7b6a4,c7d85bf8,c7d85c0c,c0252a45,c6c7b6a4,0) 
 > at netbsd:epshutdown+0x48
 > device_pmf_driver_shutdown(c6c7b6a4,0,1,1,0,c7d85d00,c7d85c2c,c025dead,0,0) 
 > at netbsd:device_pmf_driver_shutdown+0x1d
 > pmf_system_shutdown(0,0,0,c0300c6a,8,0,c7d85c3c,c0300c85,c7d85d00,0) at 
 > netbsd:pmf_system_shutdown+0x70
 > doshutdownhooks(c7d85d00,0,c7d85cdc,c026750f,0,0,c7d85c9c,c025adbb,c6924f40,1)
 >  
 > at netbsd:doshutdownhooks+0x3f
 > cpu_reboot(0,0,c7d85c9c,c025adbb,c6924f40,1,4e1c000,4e1c000,c7d85c90,c7d68b1c)
 >  
 > at netbsd:cpu_reboot+0x6e
 
 This part doesn't make sense to me; doshutdownhooks doesn't call 
 pmf_system_shutdown.
 
 In any case, give this second patch a shot.
 
 Cheers,
 Jared
 
 --------------020906010007080108090401
 Content-Type: text/plain;
  name="i82365.patch"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="i82365.patch"
 
 Index: i82365.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/ic/i82365.c,v
 retrieving revision 1.103
 diff -u -p -r1.103 i82365.c
 --- i82365.c   16 Dec 2008 22:35:31 -0000      1.103
 +++ i82365.c   4 Mar 2009 11:23:03 -0000
 @@ -1328,7 +1328,11 @@ pcic_delay(h, timo, wmesg)
  #endif
        DPRINTF(("pcic_delay: \"%s\" %p, sleep %d ms\n",
            wmesg, h->event_thread, timo));
 -      tsleep(pcic_delay, PWAIT, wmesg, roundup(timo * hz, 1000) / 1000);
 +      if (doing_shutdown)
 +              delay(timo * 1000);
 +      else
 +              tsleep(pcic_delay, PWAIT, wmesg,
 +                  roundup(timo * hz, 1000) / 1000);
  }
  
  void
 
 --------------020906010007080108090401--