Re: port-xen/40739: no entropy device sourcese on 5.0_RC2 XEN3PAE_DOMU

[Christoph Egger <Christoph_Egger%gmx.de@localhost>]

The following reply was made to PR port-xen/40739; it has been noted by GNATS.

From: Christoph Egger <Christoph_Egger%gmx.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: port-xen-maintainer%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
 netbsd-bugs%netbsd.org@localhost, gendalia%iastate.edu@localhost
Subject: Re: port-xen/40739: no entropy device sourcese on 5.0_RC2 XEN3PAE_DOMU
Date: Thu, 26 Feb 2009 00:14:09 +0100

 This is a multi-part message in MIME format.
 --------------040104040709060704000107
 Content-Type: text/plain; charset=ISO-8859-15
 Content-Transfer-Encoding: 7bit
 
 Manuel Bouyer wrote:
 >  On Wed, Feb 25, 2009 at 01:37:25PM -0600, Tracy J. Di Marco White wrote:
 >  > 'rndctl -l' doesn't list any devices, as shown above.
 >  
 >  I see, if_xennet_xenbus.c is missing a call to rnd_attach_source().
 >  It can probably be cut-n-pasted from if_xennet.c.
 >  I'll have a look next week, unless someone beats me
 
 Tracy: If this patch is ok, I'll commit it.
 
 Christoph
 
 --------------040104040709060704000107
 Content-Type: text/plain; x-mac-type="0"; x-mac-creator="0";
  name="xennet_entropy.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="xennet_entropy.diff"
 
 Index: sys/arch/xen/xen/if_xennet_xenbus.c
 ===================================================================
 RCS file: /cvsroot/src/sys/arch/xen/xen/if_xennet_xenbus.c,v
 retrieving revision 1.33
 diff -u -p -r1.33 if_xennet_xenbus.c
 --- sys/arch/xen/xen/if_xennet_xenbus.c        8 Feb 2009 19:05:50 -0000       
1.33
 +++ sys/arch/xen/xen/if_xennet_xenbus.c        25 Feb 2009 23:11:47 -0000
 @@ -378,6 +378,11 @@ xennet_xenbus_attach(device_t parent, de
                panic("%s: can't establish soft interrupt",
                        device_xname(self));
  
 +#if NRND > 0
 +      rnd_attach_source(&sc->sc_rnd_source, device_xname(sc->sc_dev),
 +          RND_TYPE_NET, 0);
 +#endif
 +
        /* initialise shared structures and tell backend that we are ready */
        xennet_xenbus_resume(sc);
  }
 
 --------------040104040709060704000107--