Re: bin/38723

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR bin/38723; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: FUKAUMI Naoki <fun%naobsd.org@localhost>, 
gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: Re: bin/38723
Date: Tue, 16 Dec 2008 12:12:45 -0500

 On Dec 17,  1:37am, fun%naobsd.org@localhost (FUKAUMI Naoki) wrote:
 -- Subject: Re: bin/38723
 
 | hi christos,
 | 
 | you didn't use 2nd patch from paul, so "AMD Power Management features"
 | is still missing. please apply attached patch, and please pullup to
 | netbsd-5.
 | 
 | [before]
 | cpu0: AMD Family 10h (686-class), 2109.84 MHz, id 0x100f23
 | cpu0: features 178bfbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR>
 | cpu0: features 178bfbff<PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX>
 | cpu0: features 178bfbff<FXSR,SSE,SSE2,HTT>
 | cpu0: features2 802009<SSE3,MONITOR,CX16,POPCNT>
 | cpu0: features3 
efd3fbff<SCALL/RET,NOX,MXX,FFXSR,P1GB,RDTSCP,LONG,3DNOW2,3DNOW>
 | cpu0: features4 
7ff<LAHF,CMPLEGACY,SVM,EAPIC,ALTMOVCR0,LZCNT,SSE4A,MISALIGNSSE,3DNOWPREFETCH,OSVW,IBS>
 | cpu0: "Quad-Core AMD Opteron(tm) Processor 1352"
 | cpu0: I-cache 64KB 64B/line 2-way, D-cache 64KB 64B/line 2-way
 | cpu0: L2 cache 1MB 64B/line 16-way
 | cpu0: ITLB 32 4KB entries fully associative, 16 4MB entries fully associative
 | cpu0: DTLB 48 4KB entries fully associative, 48 4MB entries fully associative
 | cpu0: L3 cache 2MB 64B/line 32-way
 | cpu0: Initial APIC ID 1
 | cpu0: AMD Power Management features: 
 | cpu0: family 0f model 02 extfamily 01 extmodel 00
 | 
 | [after]
 | cpu0: AMD Family 10h (686-class), 2109.84 MHz, id 0x100f23
 | cpu0: features 178bfbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR>
 | cpu0: features 178bfbff<PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX>
 | cpu0: features 178bfbff<FXSR,SSE,SSE2,HTT>
 | cpu0: features2 802009<SSE3,MONITOR,CX16,POPCNT>
 | cpu0: features3 
efd3fbff<SCALL/RET,NOX,MXX,FFXSR,P1GB,RDTSCP,LONG,3DNOW2,3DNOW>
 | cpu0: features4 
7ff<LAHF,CMPLEGACY,SVM,EAPIC,ALTMOVCR0,LZCNT,SSE4A,MISALIGNSSE,3DNOWPREFETCH,OSVW,IBS>
 | cpu0: "Quad-Core AMD Opteron(tm) Processor 1352"
 | cpu0: I-cache 64KB 64B/line 2-way, D-cache 64KB 64B/line 2-way
 | cpu0: L2 cache 1MB 64B/line 16-way
 | cpu0: ITLB 32 4KB entries fully associative, 16 4MB entries fully associative
 | cpu0: DTLB 48 4KB entries fully associative, 48 4MB entries fully associative
 | cpu0: L3 cache 2MB 64B/line 32-way
 | cpu0: Initial APIC ID 1
 | cpu0: AMD Power Management features: 1f9<TS,TTP,HTC,STC,100,HWP,TSC>
 | cpu0: family 0f model 02 extfamily 01 extmodel 00
 | 
 | --
 | FUKAUMI Naoki
 | 
 | --Multipart_Wed_Dec_17_01:37:54_2008-1
 | Content-Type: text/plain; charset=US-ASCII
 | 
 | Index: usr.sbin/cpuctl/arch/i386.c
 | ===================================================================
 | RCS file: /home/fun/cvsroot/NetBSD/src/usr.sbin/cpuctl/arch/i386.c,v
 | retrieving revision 1.13
 | diff -u -p -r1.13 i386.c
 | --- usr.sbin/cpuctl/arch/i386.c      14 Oct 2008 15:49:04 -0000      1.13
 | +++ usr.sbin/cpuctl/arch/i386.c      16 Dec 2008 16:20:51 -0000
 | @@ -1778,7 +1778,7 @@ static void
 |  powernow_probe(struct cpu_info *ci)
 |  {
 |      uint32_t regs[4];
 | -    char line[256];
 | +    char *buf;
 |  
 |      x86_cpuid(0x80000000, regs);
 |  
 | @@ -1787,7 +1787,10 @@ powernow_probe(struct cpu_info *ci)
 |              return;
 |      x86_cpuid(0x80000007, regs);
 |  
 | -    bitmask_snprintf(regs[3], CPUID_APM_FLAGS, line, sizeof(line));
 | +    buf = malloc(MAXPATHLEN);
 | +    bitmask_snprintf(regs[3], CPUID_APM_FLAGS, buf, MAXPATHLEN);
 |      aprint_normal_dev(ci->ci_dev, "AMD Power Management features: %s\n",
 | -        line);
 | +        buf);
 | +
 | +    free(buf);
 |  }
 
 But I don't see the problem in the code. Why doesn't line get filled with
 the info in the bitmask_snprintf? 256 characters is clearly enough.
 
 christos