xsrc/39851: native xorgs xdm doesn't use PAM

[spz%volans.1st.de@localhost]

>Number:         39851
>Category:       xsrc
>Synopsis:       native xorgs xdm doesn't use PAM
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    xsrc-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 02 13:05:01 +0000 2008
>Originator:     S.P.Zeidler
>Release:        NetBSD 5.0_BETA (20081101)
>Organization:
        dis-
>Environment:
System: NetBSD volans 5.0_BETA NetBSD 5.0_BETA (VOLANS) #7: Sun Nov 2 12:47:45 
CET 2008 
spz@volans:/home/netbsd/i386/obj/home/netbsd/src/sys/arch/i386/compile/VOLANS 
i386
Architecture: i386
Machine: i386
>Description:
        native xorgs xdm isn't compiled to use PAM
>How-To-Repeat:
        build & install native xorg, use xdm
>Fix:
        
Index: external/mit/xorg/bin/xdm/Makefile
===================================================================
RCS file: /cvsroot/src/external/mit/xorg/bin/xdm/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- external/mit/xorg/bin/xdm/Makefile  14 Oct 2008 23:37:19 -0000      1.3
+++ external/mit/xorg/bin/xdm/Makefile  2 Nov 2008 12:54:06 -0000
@@ -31,6 +31,11 @@
 DPADD+=                ${LIBXAU} ${LIBXDMCP} ${LIBXINERAMA} ${LIBXPM} ${LIBXMU}
 DPADD+=                ${LIBXT} ${LIBSM} ${LIBICE} ${LIBXEXT} ${LIBX11} 
${LIBCRYPT}
 
+.if (${USE_PAM} != "no")
+LDADD+= -lpam ${PAM_STATIC_LDADD}
+DPADD+= ${LIBPAM} ${PAM_STATIC_DPADD}
+.endif
+
 SUBDIR=                chooser config
 TARGETS+=      configinstall
 
Index: external/mit/xorg/bin/xdm/Makefile.xdm
===================================================================
RCS file: /cvsroot/src/external/mit/xorg/bin/xdm/Makefile.xdm,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 Makefile.xdm
--- external/mit/xorg/bin/xdm/Makefile.xdm      29 Jul 2008 05:01:22 -0000      
1.1.1.1
+++ external/mit/xorg/bin/xdm/Makefile.xdm      2 Nov 2008 12:54:06 -0000
@@ -15,4 +15,8 @@
                -I${X11SRCDIR.xdm} \
                ${X11FLAGS.VERSION}
 
+.if (${USE_PAM} != "no")
+CPPFLAGS+=      -DUSE_PAM
+.endif
+
 .PATH:         ${X11SRCDIR.xdm}

Index: external/mit/xdm/dist/greeter/greet.c
===================================================================
RCS file: /cvsroot/xsrc/external/mit/xdm/dist/greeter/greet.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 greet.c
--- external/mit/xdm/dist/greeter/greet.c       30 Jul 2008 04:15:19 -0000      
1.1.1.1
+++ external/mit/xdm/dist/greeter/greet.c       2 Nov 2008 12:55:33 -0000
@@ -694,8 +694,8 @@
     if (*response == NULL)
        return (PAM_BUF_ERR);
 
-    m = *msg;
-    r = *response;
+    m = (struct pam_message *) *msg;
+    r = (struct pam_response *) *response;
 
     for (i = 0; i < num_msg; i++ , m++ , r++) {
        char *username;