Re: kern/38501: NetBSD 4.99.60 (GENERIC) kernel does not handle shutdown -r properly on my hardware

["Michael L. Hitch" <mhitch%lightning.msu.montana.edu@localhost>]

On Thu, 9 Oct 2008, Brandon Wickelhaus wrote:

> There were a few responces, it looks like it was broken, then fixed, and then 
> broken.  I was running 4.99.4 on three DL360s and recently upgraded to 
> 4.99.72.  I can report that it no longer boots without ACPI disabled, though 
> SMP seems to work fine.  It also doesn't reboot correctly either once again 
> or still.  The 4.99.4 kernel rebooted fine!

  I have a couple of old 1st-generation DL360 that began hanging when 
trying to reboot.  I think I finally decided got tired of it enough to try 
tracking down what change caused it.  I found that revision 1.113 of
src/sys/dev/pci/pci.c seemed to be the cause.  Commenting out the effect 
of that change has cured my DL360s of failing to reboot.

  The patch I am using is:

Index: sys/dev/pci/pci.c
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/pci.c,v
retrieving revision 1.119
diff -u -r1.119 pci.c
--- sys/dev/pci/pci.c   19 Sep 2008 14:37:13 -0000      1.119
+++ sys/dev/pci/pci.c   10 Oct 2008 01:51:29 -0000
@@ -920,13 +920,13 @@
 static bool
 pci_child_shutdown(device_t dv, int how)
 {
-       struct pci_child_power *priv = device_pmf_bus_private(dv);
-       pcireg_t csr;
+//     struct pci_child_power *priv = device_pmf_bus_private(dv);
+//     pcireg_t csr;

        /* disable busmastering */
-       csr = pci_conf_read(priv->p_pc, priv->p_tag, PCI_COMMAND_STATUS_REG);
-       csr &= ~PCI_COMMAND_MASTER_ENABLE;
-       pci_conf_write(priv->p_pc, priv->p_tag, PCI_COMMAND_STATUS_REG, csr);
+//     csr = pci_conf_read(priv->p_pc, priv->p_tag, PCI_COMMAND_STATUS_REG);
+//     csr &= ~PCI_COMMAND_MASTER_ENABLE;
+//     pci_conf_write(priv->p_pc, priv->p_tag, PCI_COMMAND_STATUS_REG, csr);
        return true;
 }


--
Michael L. Hitch                        mhitch%montana.edu@localhost
Computer Consultant
Information Technology Center
Montana State University        Bozeman, MT     USA