NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

bin/39719: block/inode typo in quotacheck(8)

>Number:         39719
>Category:       bin
>Synopsis:       block/inode typo in quotacheck(8)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Oct 08 14:55:00 +0000 2008
>Originator:     Edgar Fuß
>Release:        4.0
Mathematisches Institut der Universität Bonn
There is an obvious typo in quotacheck(8).
In update(), line 558 reads (indentation removed):

 * Reset time limit if have a soft limit and were
 * previously under it, but are now over it.
if (dqbuf.dqb_bsoftlimit &&
    dqbuf.dqb_curblocks < dqbuf.dqb_bsoftlimit &&
    fup->fu_curblocks >= dqbuf.dqb_bsoftlimit)
        dqbuf.dqb_btime = 0;
if (dqbuf.dqb_isoftlimit &&
    dqbuf.dqb_curblocks < dqbuf.dqb_isoftlimit &&
    fup->fu_curblocks >= dqbuf.dqb_isoftlimit)
        dqbuf.dqb_itime = 0;
dqbuf.dqb_curinodes = fup->fu_curinodes;
dqbuf.dqb_curblocks = fup->fu_curblocks;

where the marked "blocks" should clearly be "inodes".
It would also seem more logically to me to reverse the order of the last two
assignments to keep the blocks/inodes order consistent.

less /usr/src/usr.sbin/quotacheck/quotacheck.c


Home | Main Index | Thread Index | Old Index