port-macppc/39696: mc(4) panics at attach time

[marcotrillo%gmail.com@localhost]

>Number:         39696
>Category:       port-macppc
>Synopsis:       mc(4) panics at attach time
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    port-macppc-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Oct 04 19:30:00 +0000 2008
>Originator:     Marco Trillo
>Release:        N/A
>Organization:
>Environment:
N/A
>Description:
Hi,

mc(4) panics at attach time since bus_space changes where introduced 
in the ppcoea-renovation branch and the driver was not updated according-
ly. 

Here are two reports:
<http://mail-index.netbsd.org/port-macppc/2008/09/01/msg000383.html>
<http://mail-index.netbsd.org/port-macppc/2008/09/28/msg000422.html> [at the 
bottom]

A fix is included below.


>How-To-Repeat:
Boot NetBSD -current on a machine wich mc(4) Ethernet.
>Fix:
The following patch was reported to fix the problem:

--- if_mc.c.orig        2008-09-02 01:33:10.000000000 +0200
+++ if_mc.c     2008-09-02 01:32:54.000000000 +0200
@@ -125,8 +125,9 @@

        sc->sc_txdma = mapiodev(reg[2], reg[3]);
        sc->sc_rxdma = mapiodev(reg[4], reg[5]);
+       sc->sc_regt = ca->ca_tag;
        bus_space_map(sc->sc_regt, reg[0], reg[1], 0, &sc->sc_regh);
-                                       /* XXX sc_regt is uninitialized */
+
        sc->sc_tail = 0;
        sc->sc_txdmacmd = dbdma_alloc(sizeof(dbdma_command_t) * 2);
        sc->sc_rxdmacmd = (void *)dbdma_alloc(sizeof(dbdma_command_t) * 8);