Re: kern/39525: cgd inadvertently encrypts blkno eight times to generate IV

[David Brownlee <abs%NetBSD.org@localhost>]

The following reply was made to PR kern/39525; it has been noted by GNATS.

From: David Brownlee <abs%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
netbsd-bugs%netbsd.org@localhost
Subject: Re: kern/39525: cgd inadvertently encrypts blkno eight times to
 generate IV
Date: Fri, 12 Sep 2008 14:27:24 +0100 (BST)

 On Fri, 12 Sep 2008, jo%schlaupelz.de@localhost wrote:
 
 > The patch provided below retains backwards compatibility by
 > introducing a new option "iv-method encblkno2" to cgdconfig.
 > Existing cgd volumes with "iv-method encblkno" in the config
 > file will still be handled as before.  When creating a new
 > cgd config file with cgdconfig, encblkno2 is now the default.
 > Depending on the option chosen, cgd will now either divide the
 > block length value by eight (to convert from bits to bytes)
 > or not (the old behavior).
 
        Just a thought on naming - you could rename the current
        encblkno to encblkno8 and add a new encblkno1, plus having
        the code still accept encblkno as an alias to encblkno8.
 
        That would make the new names more understandable...
 
 -- 
                David/absolute       -- www.NetBSD.org: No hype required --