toolchain/39361: build.sh misses gnu-make error when probing for nbmake

[cagney%gnu.org@localhost]

>Number:         39361
>Category:       toolchain
>Synopsis:       build.sh misses gnu-make error when probing for nbmake
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    toolchain-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Aug 15 21:05:01 +0000 2008
>Originator:     Andrew Cagney
>Release:        current
>Organization:
>Environment:
f9
>Description:
Build.sh runs a test to determine if the installed make is a berkley variant, 
gnu-make (at least version 3.81) is producing output sufficient to confuse the 
check (there's unexpected output it seems, I suspect its an sh=bash interaction 
as well).

The attached tweaks the test, checking that both the command succeeds and that 
there is output.

Index: build.sh
===================================================================
RCS file: /cvsroot/src/build.sh,v
retrieving revision 1.189
diff -p -r1.189 build.sh
*** build.sh    27 Jun 2008 21:38:36 -0000      1.189
--- build.sh    14 Aug 2008 22:10:33 -0000
*************** try_set_TOOLDIR()
*** 910,916 ****
        # Use ${guess_make} with nobomb_getmakevar
        if [ -x "${guess_make}" ]; then
                TOOLDIR=$(make="${guess_make}" nobomb_getmakevar TOOLDIR)
!               [ -n "${TOOLDIR}" ] || unset TOOLDIR
        fi
  }
  
--- 911,919 ----
        # Use ${guess_make} with nobomb_getmakevar
        if [ -x "${guess_make}" ]; then
                TOOLDIR=$(make="${guess_make}" nobomb_getmakevar TOOLDIR)
!               # Check both the status and the value.
!               [ $? -eq 0 -a -n "${TOOLDIR}" ] || unset TOOLDIR
! echo TOOLDIR=${TOOLDIR}
        fi
  }
  

>How-To-Repeat:

>Fix: