NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

kern/39309: ffs_wapbl_replay_finish() is too verbose



>Number:         39309
>Category:       kern
>Synopsis:       ffs_wapbl_replay_finish() is too verbose
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Aug 07 11:25:00 +0000 2008
>Originator:     Juan RP
>Release:        Latest and greatest
>Organization:
Not NetBSD
>Environment:
NetBSD sasha 4.99.72 NetBSD 4.99.72 (MASTER) #0: Thu Aug  7 10:42:06 CEST 2008  
juan@sasha:/home/juan/build/obj/sys/arch/amd64/compile/MASTER amd64
>Description:
After a power outage, wapbl(4) reported:

/: replaying log to disk
ffs_wapbl_replay_finish: cleaning inode 23301 size=31171 mode=100555 nlink=0
ffs_wapbl_replay_finish: cleaning inode 23306 size=1263963 mode=100444 nlink=0
ffs_wapbl_replay_finish: cleaning inode 15504 size=237883 mode=100555 nlink=0
ffs_wapbl_replay_finish: cleaning inode 9874 size=79451 mode=100555 nlink=0
ffs_wapbl_replay_finish: cleaning inode 23487 size=31171 mode=100444 nlink=0
ffs_wapbl_replay_finish: cleaning inode 23380 size=70726 mode=100555 nlink=0
ffs_wapbl_replay_finish: cleaning inode 23528 size=143022 mode=100444 nlink=0
ffs_wapbl_replay_finish: cleaning inode 23529 size=73626 mode=100444 nlink=0
ffs_wapbl_replay_finish: cleaning inode 23530 size=16830 mode=100444 nlink=0
ffs_wapbl_replay_finish: cleaning inode 23531 size=96585 mode=100444 nlink=0
ffs_wapbl_replay_finish: cleaning inode 23533 size=1968503 mode=100444 nlink=0
/usr: replaying log to disk
[...]
>How-To-Repeat:

>Fix:
Index: ffs_wapbl.c
===================================================================
RCS file: /cvsroot/src/sys/ufs/ffs/ffs_wapbl.c,v
retrieving revision 1.5
diff -b -u -p -r1.5 ffs_wapbl.c
--- ffs_wapbl.c 5 Aug 2008 13:39:29 -0000       1.5
+++ ffs_wapbl.c 7 Aug 2008 11:18:25 -0000
@@ -124,14 +124,14 @@ ffs_wapbl_replay_finish(struct mount *mp
                struct inode *ip;
                error = VFS_VGET(mp, wr->wr_inodes[i].wr_inumber, &vp);
                if (error) {
-                       printf("ffs_wapbl_replay_finish: "
+                       DPRINTF("ffs_wapbl_replay_finish: "
                            "unable to cleanup inode %" PRIu32 "\n",
                            wr->wr_inodes[i].wr_inumber);
                        continue;
                }
                ip = VTOI(vp);
                KDASSERT(wr->wr_inodes[i].wr_inumber == ip->i_number);
-               printf("ffs_wapbl_replay_finish: "
+               DPRINTF("ffs_wapbl_replay_finish: "
                    "cleaning inode %" PRIu64 " size=%" PRIu64 " mode=%o 
nlink=%d\n",
                    ip->i_number, ip->i_size, ip->i_mode, ip->i_nlink);
                KASSERT(ip->i_nlink == 0);



Home | Main Index | Thread Index | Old Index