kern/39109: gcscehci doesn't work

[ryo%nerv.org@localhost]

>Number:         39109
>Category:       kern
>Synopsis:       gcscehci doesn't work
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jul 06 07:40:00 +0000 2008
>Originator:     ryo shimizu
>Release:        NetBSD 4.99.69
>Organization:
>Environment:
NetBSD msr 4.99.67 NetBSD 4.99.67 (SA5SX04A) #32: Sun Jul  6 14:47:10 JST 2008  
ryo%moveq.nerv.org@localhost:/usr/src/sys/arch/i386/compile/SA5SX04A i386
>Description:
gscsehci doesn't work.
sc->sc.sc_bus.hci_private must be "sc", not "self".

please apply this patch.
>How-To-Repeat:
boot with gcscehci device.
"usb1: root hub problem, error=13"


NetBSD 4.99.67 (SA5SX04A) #30: Wed Jul  2 02:39:48 JST 2008
ryo%moveq.nerv.org@localhost:/usr/src/sys/arch/i386/compile/SA5SX04A
total memory = 1015 MB
avail memory = 989 MB
timecounter: Timecounters tick every 10.000 msec
timecounter: Timecounter "i8254" frequency 1193182 Hz quality 100
KOHJINSHA Co.,Ltd SA Series (Rev 1.00)
mainbus0 (root)
cpu0 at mainbus0: AMD 586-class, 498MHz, id 0x5a2
vesabios0 at mainbus0: version 2.0, Elpin Systems VGA BIOS GEODE LX
vesafb0 at vesabios0: VESA frame buffer
vesafb0: fb 800x600x16 @0x50000000
vesafb0: 937 Kb memory reported, 1 screens possible
vesafb0: one screen, so hardware scrolling not possible
vesafb0: VBE/PM 1.0
wsdisplay0 at vesafb0 kbdmux 1: console (fb, vt100 emulation)
wsmux1: connecting to wsdisplay0
pci0 at mainbus0 bus 0: configuration mode 1
pci0: i/o space, memory space enabled, rd/line, rd/mult, wr/inv ok
pchb0 at pci0 dev 1 function 0
pchb0: vendor 0x1022 product 0x2080 (rev. 0x31)
vendor 0x1022 product 0x2081 (VGA display) at pci0 dev 1 function 1 not 
configured
glxsb0 at pci0 dev 1 function 2: RNG AES
cbb0 at pci0 dev 12 function 0: vendor 0x104c product 0x8039 (rev. 0x00)
vendor 0x104c product 0x803b (miscellaneous mass storage) at pci0 dev 12 
function 2 not configured
vendor 0x104c product 0x803c (SD Host Controller system) at pci0 dev 12 
function 3 not configured
rtk0 at pci0 dev 13 function 0: Realtek 8139 10/100BaseTX (rev. 0x10)
rtk0: interrupting at irq 5
rtk0: Ethernet address 00:a0:d1:c3:9e:63
rlphy0 at rtk0 phy 7: Realtek internal PHY
rlphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto
gcscpcib0 at pci0 dev 15 function 0
gcscpcib0: vendor 0x1022 product 0x2090 (rev. 0x03)
timecounter: Timecounter "gcscpcib0" frequency 3579545 Hz quality 1000
gcscpcib0: can't alloc an MFGPT for WDT
, GPIO
gpio0 at gcscpcib0: 32 pins
viaide0 at pci0 dev 15 function 2
viaide0: Advanced Micro Devices CS5536 IDE Controller (rev. 0x01)
viaide0: bus-master DMA support present
viaide0: primary channel wired to compatibility mode
viaide0: primary channel interrupting at irq 14
atabus0 at viaide0 channel 0
viaide0: secondary channel wired to compatibility mode
viaide0: secondary channel ignored (disabled)
vendor 0x1022 product 0x2093 (audio multimedia, revision 0x01) at pci0 dev 15 
function 3 not configured
ohci0 at pci0 dev 15 function 4: vendor 0x1022 product 0x2094 (rev. 0x02)
ohci0: interrupting at irq 10
ohci0: OHCI version 1.0, legacy support
usb0 at ohci0: USB revision 1.0
gcscehci0 at pci0 dev 15 function 5: vendor 0x1022 product 0x2095 (rev. 0x02)
gcscehci0: interrupting at irq 10
gcscehci0: EHCI version 1.0
gcscehci0: companion controller, 4 ports each: ohci0
usb1 at gcscehci0: USB revision 2.0
cbb0: cacheline 0x0 lattimer 0x10
cbb0: bhlc 0x821000
cbb0: interrupting at irq 3
cardslot0 at cbb0
cardbus0 at cardslot0: bus 1
pcmcia0 at cardslot0
isa0 at gcscpcib0
pckbc0 at isa0 port 0x60-0x64
pckbd0 at pckbc0 (kbd slot)
pckbc0: using irq 1 for kbd slot
wskbd0 at pckbd0: console keyboard, using wsdisplay0
pms0 at pckbc0 (aux slot)
pms0: Synaptics touchpad version 6.3
pms0: Palm detect, Multi-finger
pckbc0: using irq 12 for aux slot
wsmouse0 at pms0 mux 0
npx0 at isa0 port 0xf0-0xff
npx0: reported by CPUID; using exception 16
apm0 at mainbus0: Advanced Power Management BIOS: Power Management spec V1.2 
(slowidle)
timecounter: Timecounter "clockinterrupt" frequency 100 Hz quality 0
usb1: root hub problem, error=13
uhub0 at usb0: vendor 0x1022 OHCI root hub, class 9/0, rev 1.00/1.00, addr 1
uhub0: 4 ports with 4 removable, self powered
IPsec: Initialized Security Association Processing.
wd0 at atabus0 drive 0: <Hitachi HTS541640J9AT00>
wd0: drive supports 16-sector PIO transfers, LBA48 addressing
wd0: 38154 MB, 77520 cyl, 16 head, 63 sec, 512 bytes/sect x 78140160 sectors
wd0: 32-bit data port
wd0: drive supports PIO mode 4, DMA mode 2, Ultra-DMA mode 5 (Ultra/100)
wd0(viaide0:0:0): using PIO mode 4, Ultra-DMA mode 5 (Ultra/100) (using DMA)
Kernelized RAIDframe activated
pad0: outputs: 44100Hz, 16-bit, stereo
audio0 at pad0: half duplex
boot device: wd0
root on wd0a dumps on wd0b
root file system type: ffs
>Fix:
Index: gcscehci.c
===================================================================
RCS file: /src/cvs/cvsroot/netbsd/src/sys/arch/i386/pci/gcscehci.c,v
retrieving revision 1.3
diff -u -r1.3 gcscehci.c
--- gcscehci.c  28 Apr 2008 20:23:25 -0000      1.3
+++ gcscehci.c  6 Jul 2008 05:11:57 -0000
@@ -105,7 +105,7 @@
        struct usb_pci *up;
 
        sc->sc.sc_dev = self;
-       sc->sc.sc_bus.hci_private = self;
+       sc->sc.sc_bus.hci_private = sc;
 
        aprint_naive(": USB controller\n");