Re: kern/38990: Unmounting a disk fails the first time

[christos%zoulas.com@localhost (Christos Zoulas)]

On Jun 22,  1:20am, dholland-bugs%netbsd.org@localhost (David Holland) wrote:
-- Subject: Re: kern/38990: Unmounting a disk fails the first time

| On Sat, Jun 21, 2008 at 07:43:22PM -0400, Christos Zoulas wrote:
|  > |  I was thinking that putting in a temporary hack of the form "sync();
|  > |  sleep(1); retry" is a lot easier at userlevel, that's all.
|  > 
|  > Are you planning to hack amd too? And everything else that uses umount()?
| 
| amd doesn't need the hack; it unmounts idle volumes. In fact... if amd
| uses EBUSY returns to test for volumes being idle, which it probably
| does, putting the workaround into the system call might hose it up.
| (Sigh.)
| 
| Anyway, this is begging the question. Is it worth putting a
| sleep/retry workaround in? I'm not entirely convinced, which is why I
| asked in the first place.

People are going to complain if we don't... I don't see why can't the kernel
retry a couple of times.

christos