Re: PR/38584 CVS commit: src/bin/sh

[Aleksey Cheusov <cheusov%tut.by@localhost>]

The following reply was made to PR bin/38584; it has been noted by GNATS.

From: Aleksey Cheusov <cheusov%tut.by@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: tron%NetBSD.org@localhost,  gnats-admin%netbsd.org@localhost,  
netbsd-bugs%netbsd.org@localhost
Subject: Re: PR/38584 CVS commit: src/bin/sh
Date: Sat, 24 May 2008 21:15:23 +0300

  >>  Port revision 1.44 of "src/bin/sh/eval.c" from FreeBSD to fix PR 
bin/38584.
  >>  Reviewed by Michael van Elst.
 >  
 >  This is not enough.
 >  case1:
 >    set -e
 >    ! true
 >    echo 'This should not happen'
 >  
 >  case2:
 >    set -e
 >  
 >    true | false &
 >    job=$!
 >  
 >    wait $job
 >    echo $?
 >  
 >    echo 'This should not happen'
 >  
 >  I'm not familiar with bin/sh source code but I think
 >  more case statements should set do_etest.
 case3:
   set -e
 
   false && false
 
   echo 'This should not happen'
 
 
 P.S.  "White box" testing and regressions tests for all case
 statements are needed.
 
 -- 
 Best regards, Aleksey Cheusov.