Re: PR/38584 CVS commit: src/bin/sh

[Aleksey Cheusov <cheusov%tut.by@localhost>]

The following reply was made to PR bin/38584; it has been noted by GNATS.

From: Aleksey Cheusov <cheusov%tut.by@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: tron%NetBSD.org@localhost,  gnats-admin%netbsd.org@localhost,  
netbsd-bugs%netbsd.org@localhost
Subject: Re: PR/38584 CVS commit: src/bin/sh
Date: Sat, 24 May 2008 20:46:12 +0300

 > The following reply was made to PR bin/38584; it has been noted by GNATS.
 
 > From: Matthias Scheler <tron%netbsd.org@localhost>
 > To: gnats-bugs%gnats.NetBSD.org@localhost
 > Cc: 
 > Subject: PR/38584 CVS commit: src/bin/sh
 > Date: Sat, 24 May 2008 17:12:53 +0000 (UTC)
 
 >  Module Name:        src
 >  Committed By:       tron
 >  Date:               Sat May 24 17:12:53 UTC 2008
 >  
 >  Modified Files:
 >      src/bin/sh: eval.c
 >  
 >  Log Message:
 >  Port revision 1.44 of "src/bin/sh/eval.c" from FreeBSD to fix PR bin/38584.
 >  Reviewed by Michael van Elst.
 
 This is not enough.
 case1:
   set -e
   ! true
   echo 'This should not happen'
 
 case2:
   set -e
 
   true | false &
   job=$!
 
   wait $job
   echo $?
 
   echo 'This should not happen'
 
 I'm not familiar with bin/sh source code but I think
 more case statements should set do_etest.
 
 -- 
 Best regards, Aleksey Cheusov.