Re: lib/38728: add support Camellia for openssl

[Tomoyuki Okazaki <okazaki%kick.gr.jp@localhost>]

christos%zoulas.com@localhost (Christos Zoulas) writes:

> The following reply was made to PR lib/38728; it has been noted by GNATS.
>
> From: christos%zoulas.com@localhost (Christos Zoulas)
> To: gnats-bugs%NetBSD.org@localhost, lib-bug-people%netbsd.org@localhost, 
>       gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
> Cc: 
> Subject: Re: lib/38728: add support Camellia for openssl
> Date: Thu, 22 May 2008 10:03:51 -0400
>
>  On May 22, 12:00pm, okazaki%kick.gr.jp@localhost 
> (okazaki%kick.gr.jp@localhost) wrote:
>  -- Subject: lib/38728: add support Camellia for openssl
>  
>  | >Number:         38728
>  | >Category:       lib
>  | >Synopsis:       add support Camellia for openssl
>  | >Confidential:   no
>  | >Severity:       non-critical
>  | >Priority:       medium
>  | >Responsible:    lib-bug-people
>  | >State:          open
>  | >Class:          change-request
>  | >Submitter-Id:   net
>  | >Arrival-Date:   Thu May 22 12:00:00 +0000 2008
>  | >Originator:     Tomoyuki Okazaki
>  | >Release:        -current
>  | >Organization:
>  | >Environment:
>  | NetBSD blackhowling 4.99.63 NetBSD 4.99.63 (GENERIC) #1: Thu May 22 
> 11:58:11 JST 2008  
> okazaki@blackhowling:/usr/obj/sys/arch/amd64/compile/GENERIC amd64
>  | 
>  | >Description:
>  | Camellia is enabled openssl 0.9.9-dev by default.
>  | I made a patch I'd like to be enabled Camellia.
>  | 
>  | >How-To-Repeat:
>  | 
>  | >Fix:
>  | patch for -current is below:
>  | 
>  |  /* The OPENSSL_NO_* macros are also defined as NO_* if the application
>  |     asks for it.  This is a transient feature that is provided for those
>  |     who haven't had the time to do the appropriate changes in their
>  |     applications.  */
>  |  #ifdef OPENSSL_ALGORITHM_DEFINES
>  | -# if defined(OPENSSL_NO_CAMELLIA) && !defined(NO_CAMELLIA)
>  | -#  define NO_CAMELLIA
>  | -# endif
>  
>  I don't think that this is needed. Also where is camellia.inc?

There is no NO_CAMELLIA lines in opensslconf.h.in, so I deleted it.
Oh, I forgot to attach camellia.inc.

----------------------------------
#       $NetBSD$
#
#

.PATH:  ${OPENSSLSRC}/crypto/camellia

CAMELLIA_SRCS = camellia.c cmll_misc.c \
    cmll_ecb.c cmll_cbc.c cmll_cfb.c cmll_ofb.c cmll_ctr.c
SRCS += ${CAMELLIA_SRCS}

.for cryptosrc in ${CAMELLIA_SRCS}
CPPFLAGS.${cryptosrc} = -I${OPENSSLSRC}/crypto/camellia
.endfor
----------------------------------

-- 
Tomoyuki Okazaki
okazaki%po.ntts.co.jp@localhost (okazaki%kick.gr.jp@localhost)