Re: kern/38637: pppoe fails to reconnect sometimes

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR kern/38637; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/38637: pppoe fails to reconnect sometimes
Date: Mon, 12 May 2008 16:43:05 +0200

 --5mCyUwZo2JvN/JJP
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Could you try if the printf in the following patch fires in the non
 working case?
 
 Thanks,
 
 Martin
 
 --5mCyUwZo2JvN/JJP
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=patch
 
 Index: if_pppoe.c
 ===================================================================
 RCS file: /cvsroot/src/sys/net/if_pppoe.c,v
 retrieving revision 1.86
 diff -u -r1.86 if_pppoe.c
 --- if_pppoe.c 28 Apr 2008 20:24:09 -0000      1.86
 +++ if_pppoe.c 12 May 2008 14:41:56 -0000
 @@ -663,8 +663,12 @@
                                free(sc->sc_ac_cookie, M_DEVBUF);
                        sc->sc_ac_cookie = malloc(ac_cookie_len, M_DEVBUF,
                            M_DONTWAIT);
 -                      if (sc->sc_ac_cookie == NULL)
 +                      if (sc->sc_ac_cookie == NULL) {
 +                              printf("%s: FATAL: could not allocate memory "
 +                                  "for AC cookie\n",
 +                                  sc->sc_sppp.pp_if.if_xname);
                                goto done;
 +                      }
                        sc->sc_ac_cookie_len = ac_cookie_len;
                        memcpy(sc->sc_ac_cookie, ac_cookie, ac_cookie_len);
                }
 
 --5mCyUwZo2JvN/JJP--