NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

kern/38565: console outputs CRLF in the "wrong" order



>Number:         38565
>Category:       kern
>Synopsis:       console outputs CRLF in the "wrong" order
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri May 02 16:45:00 +0000 2008
>Originator:     Greg A. Woods
>Release:        NetBSD current 2008/05/02
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
System: NetBSD
>Description:

        the console driver ouputs the <CR> after the <LF> instead of in
        the traditional <CR><LF> order

>How-To-Repeat:

>Fix:

        I'm pretty sure I saw this somewhere else in someone else's
        diff, but I can't find it again now

Index: sys/dev/cons.c
===================================================================
RCS file: /cvs/master/m-NetBSD/main/src/sys/dev/cons.c,v
retrieving revision 1.65
diff -u -r1.65 cons.c
--- sys/dev/cons.c      24 Jan 2008 17:32:52 -0000      1.65
+++ sys/dev/cons.c      16 Apr 2008 20:06:16 -0000
@@ -336,9 +336,9 @@
                return;
 
        if (c) {
-               (*cn_tab->cn_putc)(cn_tab->cn_dev, c);
                if (c == '\n')
                        (*cn_tab->cn_putc)(cn_tab->cn_dev, '\r');
+               (*cn_tab->cn_putc)(cn_tab->cn_dev, c);
        }
 }
 



Home | Main Index | Thread Index | Old Index