Re: kern/38535: locking bug in ifmedia_ioctl

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR kern/38535; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/38535: locking bug in ifmedia_ioctl
Date: Mon, 28 Apr 2008 22:11:48 +0200

 On Mon, Apr 28, 2008 at 07:35:01PM +0000, Andrew Doran wrote:
 >  What are 1073ab4, 1073dd4 and 1073afc?
 
 (gdb) list *( 0x1073ab4)
 0x1073ab4 is in hme_ioctl (../../../../dev/ic/hme.c:1419).
 1414    {
 1415            struct hme_softc *sc = ifp->if_softc;
 1416            struct ifaddr *ifa = (struct ifaddr *)data;
 1417            int error = 0;
 1418    
 1419            mutex_enter(&sc->sc_mutex);
 1420    
 1421            switch (cmd) {
 1422    
 1423            case SIOCSIFADDR:
 
 (gdb) list *(0x1073dd4)
 0x1073dd4 is in hme_config (../../../../dev/ic/hme.c:170).
 165              * the local Ethernet address:
 166              *      sc_enaddr
 167              *
 168              */
 169     
 170             mutex_init(&sc->sc_mutex, MUTEX_SPIN, IPL_NET);
 171     
 172             /* Make sure the chip is stopped. */
 173             hme_stop(sc, true);
 174     
 
 
 (gdb) list *(0x1073afc)
 0x1073afc is in hme_ioctl (../../../../dev/ic/hme.c:1504).
 1499                    }
 1500                    break;
 1501            }
 1502    
 1503            sc->sc_if_flags = ifp->if_flags;
 1504            mutex_exit(&sc->sc_mutex);
 1505            return (error);
 1506    }
 1507    
 1508    void