kern/38405: bogus SADB_DELETE satype value in netipsec/key.c (FAST_IPSEC)

[fukumoto%imasy.or.jp@localhost]

>Number:         38405
>Category:       kern
>Synopsis:       bogus SADB_DELETE satype value in netipsec/key.c (FAST_IPSEC)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 11 16:10:00 +0000 2008
>Originator:     fukumoto%imasy.or.jp@localhost
>Release:        NetBSD 4.0_STABLE
>Organization:
>Environment:
        
        
System: NetBSD kestrel 4.0_STABLE NetBSD 4.0_STABLE (Kestrel) #15: Tue Feb 19 
03:07:05 JST 2008 
fukumoto@kestrel:/usr/src.netbsd4/sys/arch/i386/compile/Kestrel i386
Architecture: i386
Machine: i386
>Description:

In sys/netipsec/key.c, there's line:

                        m = key_setsadbmsg(SADB_DELETE, 0,
                            d->sah->saidx.proto, 0, 0, d->refcnt - 1);

The third parameter should be SADB_SATYPE_* value, but the passed
value d->sah->saidx.proto is IPPROTO_*, which is different value.

>How-To-Repeat:
        
>Fix:

It is fixed in FreeBSD netipsec/key.c, rev. 1.9.

>Unformatted: