Re: bin/38175: comsat misunderstands NetBSD 4.0 ptyfs PTY names

[christos%zoulas.com@localhost (Christos Zoulas)]

On Mar 5,  1:51pm, eravin%panix.com@localhost (Ed Ravin) wrote:
-- Subject: Re: bin/38175: comsat misunderstands NetBSD 4.0 ptyfs PTY names

| On Wed, Mar 05, 2008 at 06:05:04PM +0000, David Holland wrote:
| > The following reply was made to PR bin/38175; it has been noted by GNATS.
| > 
| > From: David Holland <dholland-bugs%netbsd.org@localhost>
| > To: gnats-bugs%NetBSD.org@localhost
| > Cc: gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
| > Subject: Re: bin/38175: comsat misunderstands NetBSD 4.0 ptyfs PTY names
| > Date: Wed, 5 Mar 2008 18:04:00 +0000
| > 
| >  On Wed, Mar 05, 2008 at 03:40:02PM +0000, eravin%panix.com@localhost wrote:
| >   > We get these messages in syslog instead of successful notifications:
| >   > 
| >   > Mar  5 08:40:39 logsources@panix5/166.84.1.5 comsat[12662]: '/' in 
"/dev/pts/51"
| >   > 
| >   > I believe this is the code at fault in comsat.c:
| >   > 
| >   >     248     if (strncmp(cr, "pts/", 4) == 0)
| >   >     249         cr += 4;
| >   >     250     if (strchr(cr, '/')) {
| >   >     251         /* A slash is an attempt to break security... */
| >   >     252         syslog(LOG_AUTH | LOG_NOTICE, "Unexpected `/' in `%s'",
| >   >     253             ep->line);
| >   >     254         return;
| >   >     255     }
| >  
| >  Well, yes and no. The problem looks to be that the utmp file has
| >  "/dev/pts/51" in it (in the ut_line field) instead of just "pts/51",
| >  which is what would normally be expected.
| >  
| >  What do you see as the tty names when you run /usr/bin/who? And what
| >  program are you using to "log in" on these ttys that leaves it set
| >  this way? (sshd? xterm? kterm? gnome_terminal? ...?)
| 
| See below.  Original user's name and IP are obfuscated.

I wonder if this message:

    Mar  5 08:40:39 logsources@panix5/166.84.1.5 comsat[12662]: '/' in 
"/dev/pts/51"

is coming from:

    syslog(LOG_AUTH | LOG_NOTICE, "Unexpected `/' in `%s'",

since the quotes are different. It looks more similar to the string from
ttymsg.c:

    (void)snprintf(errbuf, sizeof(errbuf),
        "%s: '/' or '.' in \"%s\"", __func__, line);

but again it is not the same...

christos