Re: kern/38081: ahcisata does not attach for Intel 82801GB/GR

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

The following reply was made to PR kern/38081; it has been noted by GNATS.

From: Manuel Bouyer <bouyer%antioche.eu.org@localhost>
To: Simon Burge <simonb%NetBSD.org@localhost>
Cc: gnats-bugs%NetBSD.org@localhost, kern-bug-people%NetBSD.org@localhost, 
gnats-admin%NetBSD.org@localhost,
        netbsd-bugs%NetBSD.org@localhost
Subject: Re: kern/38081: ahcisata does not attach for Intel 82801GB/GR
Date: Fri, 22 Feb 2008 23:26:38 +0100

 On Fri, Feb 22, 2008 at 11:50:10PM +1100, Simon Burge wrote:
 > The attached patch changes the behavour from something like:
 > 
 >      if (SATA_AHCI || RAID)
 >              return match if ACHI mode;
 > 
 > to
 > 
 >      if (SATA_AHCI || RAID)
 >              if (SATA_ACHI)
 >                      return match;
 >              else if (ACHI enable bit)
 >                      return match;
 > 
 > I think we're right to not blindly attach to any card that is
 > PCI_SUBCLASS_MASS_STORAGE_RAID as rev 1.3 of ahcisata_pci.c did.
 
 Sure
 
 > However, I'm not sure what you attach such a device if it doesn't have
 > AHCI_GHC_AE set...
 
 ahci_reset() will set AHCI_GHC_AE. it's OK as long as we're sure it's
 an ACHI device. If the class is AHCI, then we're sure. I think your
 patch is correct.
 
 -- 
 Manuel Bouyer <bouyer%antioche.eu.org@localhost>
      NetBSD: 26 ans d'experience feront toujours la difference
 --