Re: toolchain/37938: Solaris 10 / SPARC hosted build of NetBSD fails in MAKEDEV.awk

[Palle Lyckegaard <palle%lyckegaard.dk@localhost>]

On Sat, 2 Feb 2008, Alan Barrett wrote:

> Date: Sat,  2 Feb 2008 19:00:06 +0000 (UTC)
> From: Alan Barrett <apb%cequrux.com@localhost>
> Reply-To: gnats-bugs%NetBSD.org@localhost
> To: toolchain-manager%NetBSD.org@localhost, gnats-admin%NetBSD.org@localhost,
>     netbsd-bugs%NetBSD.org@localhost, palle%lyckegaard.dk@localhost
> Subject: Re: toolchain/37938: Solaris 10 / SPARC hosted build of NetBSD fails
>     in MAKEDEV.awk
>
> The following reply was made to PR toolchain/37938; it has been noted by GNATS.
>
> From: Alan Barrett <apb%cequrux.com@localhost>
> To: gnats-bugs%NetBSD.org@localhost
> Cc: netbsd-bugs%NetBSD.org@localhost
> Subject: Re: toolchain/37938: Solaris 10 / SPARC hosted build of NetBSD
>         fails in MAKEDEV.awk
> Date: Sat, 2 Feb 2008 17:42:18 +0200
>
> On Fri, 01 Feb 2008, palle%lyckegaard.dk@localhost wrote:
> > The attached patch to src/etc/MAKEDEV.awk removes an issue with building
> > NetBSD on a Solaris 10 / SPARC hosted system (with PATH as described in
> > src/tools/compat/README)
>
> What's the exact error message?

"ERROR: no entry for ''cons' in majors file"
> > 84d83
> > <
> > 96c95
> > <       if ( length(CONSOLE_CMAJOR) == 0) {
> > ---
> > >       if (CONSOLE_CMAJOR == "") {
>
> (In future, please submit patches in unidiff format, as produced by
> "cvs diff -u".)

new (properly) patch attached...
> MAKEDEV.awk already contains the line 'if (CONSOLE_CMAJOR == "") {'.
> If you have a copy with 'if ( length(CONSOLE_CMAJOR) == 0) {' then
> I don't know where you obtained it.
>
> As far as I can tell from reading
> <http://www.opengroup.org/onlinepubs/009695399/utilities/awk.html>,
> both variants should be acceptable.
>
> --apb (Alan Barrett)

--
--
                  ,      ,
       o    .    /(,----.)\        o
       |   /,\   \' ^  ^ `/        |
       |   ((    | (o)(o) |        |
  _____|____\\.OOOo_(__)_oOOO._____|_____
 /                                       \
 )                 NetBSD                (
 \_____________________Oooo._____________/
       |       .oooO   (   )       |
     ,---.     (   )    ) /      ,---.
     | | |      \ (    (_/       | | |
     V V V       \_)             V V V

Index: MAKEDEV.awk
===================================================================
RCS file: /cvsroot/src/etc/MAKEDEV.awk,v
retrieving revision 1.19
diff -u -r1.19 MAKEDEV.awk
--- MAKEDEV.awk 10 Dec 2007 17:57:24 -0000      1.19
+++ MAKEDEV.awk 2 Feb 2008 19:58:01 -0000
@@ -92,7 +92,7 @@
                close(file)
        }
        CONSOLE_CMAJOR = chr["cons"]
-       if (CONSOLE_CMAJOR == "") {
+       if ( length(CONSOLE_CMAJOR) == 0) {
                print "ERROR: no entry for 'cons' in majors file" > 
"/dev/stderr"
                exit 1
        }