kern/37717: raidclose() no longer called on shutdown...

[oster%netbsd.org@localhost]

>Number:         37717
>Category:       kern
>Synopsis:       raidclose() is no longer called on shutdown
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jan 08 15:55:00 +0000 2008
>Originator:     oster%netbsd.org@localhost
>Release:        NetBSD 4.99.48
>Organization:
>Environment:
System: NetBSD 4.99.48 (RAIDFRAME.ddbLD) #6: Mon Jan  7 17:01:28 CST 2008
        oster@quad:/u1/devel/current/src/sys/arch/i386/compile/RAIDFRAME.ddbLD
Architecture: i386
Machine: i386
>Description:
        Sometime in the last little while it appears that RAIDframe
RAID sets are always marked 'dirty' after a reboot, even if they were
'clean' before.  It has not been determined when this issue started,
exactly.

In a nutshell, rf_netbsdkintf.c:raidclose() is no longer being called
when a filesystem on a RAID set is unmounted -- e.g. unmounting /
(/dev/raid0a) no longer calls raidclose().  With raidclose() not being
called, the "parity is clean" bit never gets set in the component
labels.

>How-To-Repeat:
        raidctl -vP raid0
        raidctl -s raid0
observe that parity status is "clean".
        shutdown -r now
        raidctl -s raid0
observe that partiy status is "DIRTY", when it really should be
"clean".
>Fix:
        Something is no longer calling raidclose().  Find said
something, and bat it around the ears until it calls raidclose() at
the appropriate times.  Please.