Subject: Re: port-m68k/37631: m68k libc broken
To: None <port-m68k-maintainer@netbsd.org, gnats-admin@netbsd.org,>
From: ITOH Yasufumi <itohy@NetBSD.org>
List: netbsd-bugs
Date: 12/28/2007 15:50:01
The following reply was made to PR port-m68k/37631; it has been noted by GNATS.

From: itohy@NetBSD.org (ITOH Yasufumi)
To: gnats-bugs@NetBSD.org
Cc: port-m68k-maintainer@NetBSD.org, gnats-admin@NetBSD.org,
	netbsd-bugs@NetBSD.org, martin@duskware.de
Subject: Re: port-m68k/37631: m68k libc broken
Date: Sat, 29 Dec 2007 00:45:56 +0900

 Hello,
 
 martin@duskware.de writes:
 > Is this ok to commit?
 
 > Index: m68k_syscall.c
 > ===================================================================
 > RCS file: /cvsroot/src/sys/arch/m68k/m68k/m68k_syscall.c,v
 > retrieving revision 1.30
 > diff -c -u -r1.30 m68k_syscall.c
 > --- m68k_syscall.c	17 Oct 2007 19:55:12 -0000	1.30
 > +++ m68k_syscall.c	28 Dec 2007 14:41:35 -0000
 > @@ -288,6 +288,8 @@
 >  			if (p->p_emul != &emul_netbsd_aoutm68k)
 >  				frame->f_regs[A0] = rval[0];
 >  		}
 > +#else
 > +		frame->f_regs[A0] = rval[0];
 >  #endif
 >  		break;
 >  	case ERESTART:
 
 This should be in libc to avoid adding clock cycles to unrelated
 system calls.
 See shmat(2) stub.
 
 Every system calls returning pointer requires special stub
 for m68k SVR4 ABI (aka ELF).
 
 Regards,
 -- 
 ITOH Yasufumi