Subject: kern/37259: Typo in puc(4) description for Exar XR17C158 8-channel UART
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: Daniel Neri <daniel.neri@sigicom.se>
List: netbsd-bugs
Date: 11/01/2007 13:00:01
>Number:         37259
>Category:       kern
>Synopsis:       Typo in puc(4) description for Exar XR17C158 8-channel UART
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Nov 01 13:00:00 +0000 2007
>Originator:     Daniel Neri
>Release:        NetBSD 3.1_STABLE
>Organization:
Daniel Néri <daniel.neri@sigicom.se>
Sigicom AB, Stockholm, Sweden
>Environment:
System: NetBSD dual.hq.sigicom.net 3.1_STABLE NetBSD 3.1_STABLE (DUAL) #0: Tue Jul 3 13:25:17 CEST 2007 dne@dual.hq.sigicom.net:/usr/src/sys/arch/i386/compile/DUAL i386
Architecture: i386
Machine: i386
>Description:
There's a typo in the XR17C158 8-channel UART pucdata description. The
correct PCI product ID is 0x0158.

>Fix:

Index: dev/pci/pucdata.c
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/pucdata.c,v
retrieving revision 1.40.2.4
diff -p -U5 -r1.40.2.4 pucdata.c
--- dev/pci/pucdata.c	20 Nov 2006 15:49:38 -0000	1.40.2.4
+++ dev/pci/pucdata.c	1 Nov 2007 11:49:47 -0000
@@ -1082,11 +1082,11 @@ const struct puc_device_description puc_
 		{ PUC_PORT_TYPE_COM, 0x10, 0x0400, COM_FREQ * 8 },
 		{ PUC_PORT_TYPE_COM, 0x10, 0x0600, COM_FREQ * 8 },
 	    },
 	},
 	{   "EXAR XR17D158",
-	    {   0x13a8, 0x0154, 0,      0       },
+	    {   0x13a8, 0x0158, 0,      0       },
 	    {   0xffff, 0xffff, 0,      0       },
 	    {
 		{ PUC_PORT_TYPE_COM, 0x10, 0x0000, COM_FREQ * 8 },
 		{ PUC_PORT_TYPE_COM, 0x10, 0x0200, COM_FREQ * 8 },
 		{ PUC_PORT_TYPE_COM, 0x10, 0x0400, COM_FREQ * 8 },