Subject: Re: kern/36969: locking cleanup patches for limit structures
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: Takahiro Kambe <taca@back-street.net>
List: netbsd-bugs
Date: 09/15/2007 12:45:02
The following reply was made to PR kern/36969; it has been noted by GNATS.

From: Takahiro Kambe <taca@back-street.net>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: kern/36969: locking cleanup patches for limit structures
Date: Sat, 15 Sep 2007 21:44:38 +0900 (JST)

 In message <20070911204500.BE65163B89F@narn.NetBSD.org>
 	on Tue, 11 Sep 2007 20:45:00 +0000 (UTC),
 	dholland@eecs.harvard.edu wrote:
 > Index: sys/compat/netbsd32/netbsd32_netbsd.c
 > ===================================================================
 > RCS file: /cvsroot/src/sys/compat/netbsd32/netbsd32_netbsd.c,v
 > retrieving revision 1.126
 > diff -u -p -r1.126 netbsd32_netbsd.c
 > --- sys/compat/netbsd32/netbsd32_netbsd.c	15 Aug 2007 12:07:31 -0000	1.126
 > +++ sys/compat/netbsd32/netbsd32_netbsd.c	11 Sep 2007 01:31:25 -0000
 > @@ -2298,13 +2298,7 @@ netbsd32_adjust_limits(struct proc *p)
 >  		return;
 >  	}
 >  
 > -	if (p->p_limit->p_refcnt > 1 &&
 > -	    (p->p_limit->p_lflags & PL_SHAREMOD) == 0) {
 > -		struct plimit *oldplim;
 > -		oldplim = p->p_limit;
 > -		p->p_limit = limcopy(p);
 > -		limfree(oldplim);
 > -	}
 > +	limprivatize(p);
 limprivatize() needs one more argument, dosen't it?
 
 -- 
 Takahiro Kambe <taca@back-street.net>