Subject: kern/36036: [PATCH] uhub(4) 1.85 -> 1.86 breaks build of DEBUG kernel
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: None <lkundrak@redhat.com>
List: netbsd-bugs
Date: 03/19/2007 11:00:00
>Number:         36036
>Category:       kern
>Synopsis:       [PATCH] uhub(4) 1.85 -> 1.86 breaks build of DEBUG kernel
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 19 11:00:00 +0000 2007
>Originator:     Lubomir Kundrak
>Release:        
>Organization:
>Environment:
>Description:
DPRINTF() statement in USB_MATCH() still contains a reference to usb_device_descriptor_t *dd, which was removed in revision 1.86. As it looks that the structure in question got merged with uaa, I suggest using it in the statement instead.
>How-To-Repeat:
Try to build -current DEBUG kernel with uhub(4) driver.
>Fix:
Index: sys/dev/usb/uhub.c
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/uhub.c,v
retrieving revision 1.87
diff -p -u -r1.87 uhub.c
--- sys/dev/usb/uhub.c  15 Mar 2007 15:29:09 -0000      1.87
+++ sys/dev/usb/uhub.c  19 Mar 2007 10:48:34 -0000
@@ -133,7 +133,7 @@ USB_MATCH(uhub)
 {
        USB_MATCH_START(uhub, uaa);

-       DPRINTFN(5,("uhub_match, dd=%p\n", dd));
+       DPRINTFN(5,("uhub_match, uaa=%p\n", uaa));
        /*
         * The subclass for hubs seems to be 0 for some and 1 for others,
         * so we just ignore the subclass.