Subject: Re: kern/34935: if_re_pci.c needs updating
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: Perry E. Metzger <perry@piermont.com>
List: netbsd-bugs
Date: 10/30/2006 17:55:02
The following reply was made to PR kern/34935; it has been noted by GNATS.
From: "Perry E. Metzger" <perry@piermont.com>
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Cc: gnats-bugs@NetBSD.org, kern-bug-people@NetBSD.org,
gnats-admin@NetBSD.org, netbsd-bugs@NetBSD.org
Subject: Re: kern/34935: if_re_pci.c needs updating
Date: Mon, 30 Oct 2006 12:47:39 -0500
Izumi Tsutsui <tsutsui@ceres.dti.ne.jp> writes:
>> Again, I can't absolutely confirm that their fixes
>> work without actually trying them, but I see no reason that I need to
>> have fixed a problem before filing a PR.
>
> You don't have to fix the problem before filing PR.
> But at least you should confirm our driver has any actual
> problem,
We don't have the fix FreeBSD did for the checksum issue -- turning
off the checksum assists is not a fix.
I'm going to out and out refuse right here -- I'm not going to buy a
lot of used ethernet cards, set up a test lab and attempt to reproduce
that issue when the hardware checksum assists are turned on. It is
quite well known and I don't see that there is anything to be gained
by my re-doing what other people have already done. If you can't trust
Bill Paul to be right on this, how could you trust him to have written
the correct driver in the first place? It is his code.
I also don't see why we need to pull their fixes selectively -- that
has the major effect of rendering our code unmaintainable because we
cannot get the benefit of regular synchronization with the original
author's work.
If you want to close the PR with "NetBSD doesn't want to fix problems
fixed in FreeBSD", please, go ahead.
This whole conversation has been useless from the beginning. I sent
that PR so I wouldn't forget to try to pull in the FreeBSD fixes, and
since then you've been sending mail saying "it is wrong of you to want
to update the driver". Well, I don't see why it is wrong.
Perry