perry@piermont.com wrote:

> Clearly the PR makes plenty of sense. There are documented issues that
> FreeBSD has fixed.

Then, it's much better to document each of them also in this PR.

> Again, I can't absolutely confirm that their fixes
> work without actually trying them, but I see no reason that I need to
> have fixed a problem before filing a PR.

You don't have to fix the problem before filing PR.
But at least you should confirm our driver has any actual
problem, and you should also confirm if provided fix solves
your problem by testing it on real hardware or code inspection.

> I suspect that most of their fixes should be pulled "blindly" -- we
> pulled their driver "blindly" after all, assuming that it was
> correctly written.

IIRC, jonathan@ asked on tech-kern how re(4) driver should
be imported, and kanaoka@ also asked me how bus_dma(9) code
should be modified before committing cardbus attachment.
IMHO, we should keep such proper procedures.
---
Izumi Tsutsui