Subject: Re: kern/34751: regular panics in tcp_sack_option on NetBSD/alpha 3.0_STABLE
To: None <gnats-bugs@NetBSD.org>
From: Alan Barrett <apb@cequrux.com>
List: netbsd-bugs
Date: 10/20/2006 15:31:20
On Fri, 20 Oct 2006, Reinoud Zandijk wrote:
>  Only point of improval could be the usage of `uint8_t' instead of `char' 
>  since that has an implicit assumption that sizeof(char)=1.

sizeof(char) = 1 by definition of how sizeof works.  sizeof measures in
units of chars, no matter how big a char actually is.

Assuming that a char is the same as an octet is nonportable, however, so
having network code use uint8_t instead of char seems reasonable to me.

--apb (Alan Barrett)