Subject: PR/34751 CVS commit: src/sys/netinet
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: Reinoud Zandijk <reinoud@netbsd.org>
List: netbsd-bugs
Date: 10/20/2006 13:15:10
The following reply was made to PR kern/34751; it has been noted by GNATS.
From: Reinoud Zandijk <reinoud@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: PR/34751 CVS commit: src/sys/netinet
Date: Fri, 20 Oct 2006 13:11:09 +0000 (UTC)
Module Name: src
Committed By: reinoud
Date: Fri Oct 20 13:11:09 UTC 2006
Modified Files:
src/sys/netinet: tcp_sack.c
Log Message:
Fix alignment problems causing regular panics in tpc_sack_option on
NetBSD/alpha and NetBSD/sparc. This fixes PR#34751.
The problem most likely started to show in gcc4 and is caused by the use of
a casting to an uint32_t pointer that is later copied from using memcpy.
Gcc detects the copying of 4 bytes from an uint32_t pointer and decides to
just replace it with an aligned copy causing the trap.
Fix provided by Izumi Tsutsui and ok'd by Martin.
To generate a diff of this commit:
cvs rdiff -r1.19 -r1.20 src/sys/netinet/tcp_sack.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.