Subject: Re: kern/34751: regular panics in tcp_sack_option on NetBSD/alpha 3.0_STABLE
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
List: netbsd-bugs
Date: 10/20/2006 12:00:04
The following reply was made to PR kern/34751; it has been noted by GNATS.
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
To: reinoud@NetBSD.org
Cc: netbsd-bugs@NetBSD.org, gnats-bugs@NetBSD.org,
tsutsui@ceres.dti.ne.jp
Subject: Re: kern/34751: regular panics in tcp_sack_option on NetBSD/alpha 3.0_STABLE
Date: Fri, 20 Oct 2006 20:55:43 +0900
reinoud@NetBSD.org wrote:
> Only point of improval could be the usage of `uint8_t' instead of `char'
> since that has an implicit assumption that sizeof(char)=1.
I chose (char *) because (IIRC) it is explicitly mentioned in ISO C89
that it won't cause aliases. (I think sizeof(char) is always 1, BTW)
Anyway, if you can confirm the patch actually fixes the problem,
please commit it and close the PR.
---
Izumi Tsutsui