Subject: Re: bin/34750: string handling cleanup for rogue(6)
To: None <gnats-admin@netbsd.org, netbsd-bugs@netbsd.org,>
From: Christian Biere <christianbiere@gmx.de>
List: netbsd-bugs
Date: 10/12/2006 00:55:03
The following reply was made to PR bin/34750; it has been noted by GNATS.
From: Christian Biere <christianbiere@gmx.de>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: bin/34750: string handling cleanup for rogue(6)
Date: Thu, 12 Oct 2006 02:51:04 +0200
dholland@eecs.harvard.edu wrote:
> rogue has a lot of dodgy string handling. The worst (and the
> glaringly exploitable) has already been fixed; this patch gets
> rid of sprintf, unchecked strcpy, and so forth, and also
> cleans up the score file handling.
Please utilize GCC's format string check feature:
http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html
Other examples are in /usr/include/stdio.h.
--
Christian