Subject: minor follow-on to kern/33966
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: None <dholland@eecs.harvard.edu>
List: netbsd-bugs
Date: 10/10/2006 23:10:03
The following reply was made to PR kern/33966; it has been noted by GNATS.

From: dholland@eecs.harvard.edu
To: gnats-bugs@NetBSD.org
Cc: 
Subject: minor follow-on to kern/33966
Date: Tue, 10 Oct 2006 19:03:41 -0400 (EDT)

 >Submitter-Id:	net
 >Originator:	David A. Holland
 >Organization:
    Harvard EECS
 >Confidential:	no
 >Synopsis:	sign mismatch of printf formats in scsipi/cd.c
 >Severity:	non-critical
 >Priority:	medium
 >Category:	kern
 >Class:		sw-bug
 >Release:	NetBSD 3.99.21 (20061007; -r1.250 of cd.c)
 >Environment:
 System: NetBSD weatherwax 3.99.21 NetBSD 3.99.21 (WEATHERWAX) #1: Mon Jul 10 12:28:08 EDT 2006 dholland@weatherwax:/usr/src/sys/arch/i386/compile/WEATHERWAX i386
 Architecture: i386
 Machine: i386
 >Description:
 
 kern/33966 (about a -Wsign-compare issue in sys/dev/scsipi/cd.c) was
 obsoleted by rev 1.248 of cd.c. After fixing the merge conflicts in
 the tree containing the patch I'd sent, I discovered the committed
 change hadn't updated one of the printf formats.
 
 not a big deal, but worth fixing.
 
 >How-To-Repeat:
 -
 >Fix:
 
 patch:
 
 Index: sys/dev/scsipi/cd.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/scsipi/cd.c,v
 retrieving revision 1.250
 diff -u -r1.250 cd.c
 --- sys/dev/scsipi/cd.c	8 Sep 2006 00:33:18 -0000	1.250
 +++ sys/dev/scsipi/cd.c	10 Oct 2006 22:59:05 -0000
 @@ -1750,7 +1750,7 @@
  	cd->params.disksize512 = ((u_int64_t)cd->params.disksize * blksize) / DEV_BSIZE;
  
  	SC_DEBUG(cd->sc_periph, SCSIPI_DB2,
 -	    ("cd_size: %d %ld\n", blksize, size));
 +	    ("cd_size: %u %lu\n", blksize, size));
  
  	return size;
  }