On Oct 8,  4:55am, christianbiere@gmx.de (Christian Biere) wrote:
-- Subject: Re: kern/34751: regular panics in tcp_sack_option on NetBSD/alpha

Breaks on big endian machines.

christos

|  +static inline u_int32_t
|  +peek_be32(const void *p)
|  +{
|  +	const u_int8_t *u8 = p;
|  +	return	((u_int32_t) u8[0] << 24) |
|  +		((u_int32_t) u8[1] << 16) |
|  +		((u_int32_t) u8[2] << 8) |
|  +		((u_int32_t) u8[3]);
|  +}
|  +
|   void
|   tcp_new_dsack(struct tcpcb *tp, tcp_seq seq, u_int32_t len)
|   {
|  @@ -223,10 +233,8 @@
|   	num_sack_blks = optlen / 8;
|   	acked = (SEQ_GT(th->th_ack, tp->snd_una)) ? th->th_ack : tp->snd_una;
|   	for (i = 0; i < num_sack_blks; i++, lp += 2) {
|  -		memcpy(&left, lp, sizeof(*lp));
|  -		memcpy(&right, lp + 1, sizeof(*lp));
|  -		left = ntohl(left);
|  -		right = ntohl(right);
|  +		left = peek_be32(lp);
|  +		right = peek_be32(lp + 1);
|   
|   		if (SEQ_LEQ(right, acked) || SEQ_GT(right, tp->snd_max) ||
|   		    SEQ_GEQ(left, right)) {
|  
-- End of excerpt from Christian Biere