>Number:         33697
>Category:       kern
>Synopsis:       kernels with "option APPLE_UFS" build failure (i386, sparc)
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jun 11 02:20:00 +0000 2006
>Originator:     John D. Baker
>Release:        NetBSD-current/i386, /sparc
>Organization:
>Environment:
NetBSD verthandi 3.99.19 NetBSD 3.99.19 (VERTHANDI) #0: Sat May 13 16:48:55 CDT 2006  sysop@verthandi:/space/nbsd/usr/src/sys/arch/i386/compile/VERTHANDI i386

NetBSD jean 3.99.21 NetBSD 3.99.21 (JEAN) #1: Sat Jun 10 19:43:15 CDT 2006  sysop@jean:/dsk0/nbsd/usr/src/sys/arch/sparc/compile/JEAN sparc

>Description:
Building kernels with "option APPLE_UFS" fails as follows:

#   compile  VERTHANDI/ffs_appleufs.o
/space/nbsd/usr/bin/i386--netbsdelf-gcc -ffreestanding -fno-zero-initialized-in-
bss -march=pentium2 -mmmx -march=pentium2 -mmmx -O2 -Werror -Wall -Wno-main -Wno
-format-zero-length -Wpointer-arith -Wmissing-prototypes -Wstrict-prototypes -Ws
witch -Wshadow -Wcast-qual -Wwrite-strings -Wno-sign-compare -Di386 -I. -I/usr/s
rc/sys/../common/include -I/usr/src/sys/arch -I/usr/src/sys -nostdinc -DLKM -DMA
XUSERS=32 -D_KERNEL -D_KERNEL_OPT -I/usr/src/sys/lib/libkern/../../../common/lib
/libc/quad -I/usr/src/sys/lib/libkern/../../../common/lib/libc/string -I/usr/src
/sys/lib/libkern/../../../common/lib/libc/arch/i386/string -I/usr/src/sys/dist/p
f -I/usr/src/sys/dist/ipf -c /usr/src/sys/ufs/ffs/ffs_appleufs.c
/usr/src/sys/ufs/ffs/ffs_appleufs.c: In function `ffs_appleufs_set':
/usr/src/sys/ufs/ffs/ffs_appleufs.c:135: error: `time' undeclared (first use in 
this function)
/usr/src/sys/ufs/ffs/ffs_appleufs.c:135: error: (Each undeclared identifier is r
eported only once
/usr/src/sys/ufs/ffs/ffs_appleufs.c:135: error: for each function it appears in.
)

*** Failed target:  ffs_appleufs.o
*** Failed command: echo '# ' "compile VERTHANDI/ffs_appleufs.o"; echo /space/nb
sd/usr/bin/i386--netbsdelf-gcc -ffreestanding -fno-zero-initialized-in-bss -marc
h=pentium2 -mmmx -march=pentium2 -mmmx -O2 -Werror -Wall -Wno-main -Wno-format-z
ero-length -Wpointer-arith -Wmissing-prototypes -Wstrict-prototypes -Wswitch -Ws
hadow -Wcast-qual -Wwrite-strings -Wno-sign-compare -Di386 -I. -I/usr/src/sys/..
/common/include -I/usr/src/sys/arch -I/usr/src/sys -nostdinc -DLKM -DMAXUSERS=32
 -D_KERNEL -D_KERNEL_OPT -I/usr/src/sys/lib/libkern/../../../common/lib/libc/qua
d -I/usr/src/sys/lib/libkern/../../../common/lib/libc/string -I/usr/src/sys/lib/
libkern/../../../common/lib/libc/arch/i386/string -I/usr/src/sys/dist/pf -I/usr/
src/sys/dist/ipf -c /usr/src/sys/ufs/ffs/ffs_appleufs.c; /space/nbsd/usr/bin/i38
6--netbsdelf-gcc -ffreestanding -fno-zero-initialized-in-bss -march=pentium2 -mm
mx -march=pentium2 -mmmx -O2 -Werror -Wall -Wno-main -Wno-format-zero-length -Wp
ointer-arith -Wmissing-prototypes -Wstrict-prototypes -Wswitch -Wshadow -Wcast-q
ual -Wwrite-strings -Wno-sign-compare -Di386 -I. -I/usr/src/sys/../common/includ
e -I/usr/src/sys/arch -I/usr/src/sys -nostdinc -DLKM -DMAXUSERS=32 -D_KERNEL -D_
KERNEL_OPT -I/usr/src/sys/lib/libkern/../../../common/lib/libc/quad -I/usr/src/s
ys/lib/libkern/../../../common/lib/libc/string -I/usr/src/sys/lib/libkern/../../
../common/lib/libc/arch/i386/string -I/usr/src/sys/dist/pf -I/usr/src/sys/dist/i
pf -c /usr/src/sys/ufs/ffs/ffs_appleufs.c
*** Error code 1

Stop.
nbmake: stopped in /space/nbsd/usr/src/sys/arch/i386/compile/VERTHANDI

ERROR: Failed to make all in /space/nbsd/usr/src/sys/arch/i386/compile/VERTHANDI
*** BUILD ABORTED ***


The above example is on i386, but the failure is the same on sparc.
>How-To-Repeat:
Create a kernel configuration which includes:

option APPLE_UFS

and attempt to build that kernel
>Fix:
The recent merge of the timecounters support seems to have overlooked
ffs_appleufs.c.

Maybe it's only an issue on ports other than macppc?  I enable APPLE_UFS
on i386 and sparc for purposes of sharing media with my MacOS X systems.