Subject: kern/33567: emuxki(4) attach message does not follow standard practice
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: None <rherdware@yahoo.com>
List: netbsd-bugs
Date: 05/26/2006 21:25:00
>Number:         33567
>Category:       kern
>Synopsis:       emuxki(4) attach message does not follow standard practice
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri May 26 21:25:00 +0000 2006
>Originator:     Björn Johannesson
>Release:        3.99.20 (all versions with emuxki support)
>Organization:
>Environment:
NetBSD hallabo.localdomain (HALLABO) #1: Thu 25 May 18:54:30 CEST 2006 root@hallabo.localdomain:/sys/arch/i386/compile/HALLABO i386
>Description:
The dmesg output when emuxki(4) attaches looks like this:
emuxki0 at pci0 dev 17 function 0: Creative Labs SBLive! EMU 10000 (audio multimedia, revision 0x07)
emuxki0: ac97: SigmaTel STAC9721/23 codec; 18 bit DAC, 18 bit ADC, SigmaTel 3D
emuxki0: ac97: ext id 200<AMAP>
audio0 at emuxki0: full duplex, mmap, independent
emuxki0: interrupting at irq 11

while it should look like:
emuxki0 at pci0 dev 17 function 0: Creative Labs SBLive! EMU 10000 (audio multimedia, revision 0x07)
emuxki0: interrupting at irq 11
emuxki0: ac97: SigmaTel STAC9721/23 codec; 18 bit DAC, 18 bit ADC, SigmaTel 3D
emuxki0: ac97: ext id 200<AMAP>
audio0 at emuxki0: full duplex, mmap, independent

to follow what drivers normally print... "audio0 at emuxki0"... should come after all emuxki0 messages.
>How-To-Repeat:
Boot a system with a emuxki(4) card, look at the boot messages.
>Fix:
--- emuxki.c.orig	2006-05-26 22:45:16.000000000 +0200
+++ emuxki.c	2006-05-25 18:53:28.000000000 +0200
@@ -451,6 +451,7 @@
 		bus_space_unmap(sc->sc_iot, sc->sc_ioh, sc->sc_ios);
 		return;
 	}
+	aprint_normal("%s: interrupting at %s\n", sc->sc_dev.dv_xname, intrstr);
 
  /* XXX it's unknown whether APS is made from Audigy as well */
 	if (PCI_PRODUCT(pa->pa_id) == PCI_PRODUCT_CREATIVELABS_AUDIGY) {
@@ -478,7 +479,6 @@
 		emuxki_pci_shutdown(sc);
 		return;
 	}
-	aprint_normal("%s: interrupting at %s\n", sc->sc_dev.dv_xname, intrstr);
 #if 0
 	sc->rsourcectl.dev =
 	    sc->codecif->vtbl->get_portnum_by_name(sc->codec_if, AudioCrecord,

If this get mangled with the webform:
the
aprint_normal("%s: interrupting at %s\n", sc->sc_dev.dv_xname, intrstr);
line should be at line 454, not at line 481 in emuxki.c as it is now.