Subject: port-playstation2/32728: [gsfb] Cursor 7x15 instead of 8x16
To: None <port-playstation2-maintainer@netbsd.org, gnats-admin@netbsd.org,>
From: None <ed@fxq.nl>
List: netbsd-bugs
Date: 02/04/2006 11:45:01
>Number:         32728
>Category:       port-playstation2
>Synopsis:       [gsfb] Cursor 7x15 instead of 8x16
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-playstation2-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Feb 04 11:45:00 +0000 2006
>Originator:     Ed Schouten
>Release:        NetBSD 3.99.15
>Organization:
n/a
>Environment:
System: NetBSD sony.fxq.nl 3.99.15 NetBSD 3.99.15 (SONY) #0: Sat Feb  4 01:14:20 CET 2006  root@compy.fxq.nl:/usr/obj/sys/arch/playstation2/compile/SONY playstation2
Architecture: mipsel
Machine: playstation2

>Description:
The gsfb console driver has the ability to render a block cursor. The
console font is 8x16 big, but the cursor is drawn 7x15.

>How-To-Repeat:
1. Start the screen(1) utility (locally or on a remote box).
2. Press `^A [' (copy)
3. Place the cursor on top of some text
4. You can now see a small border around the cursor (bottom and right)

>Fix:
Below is a small patch for 'gsfb.c' located in 'src/sys/arch/playstation2/ee':

%%%
--- gsfb.c	2005-12-25 00:24:01.000000000 +0100
+++ gsfb.c	2006-02-04 12:32:01.000000000 +0100
@@ -400,8 +400,8 @@
 	x *= w;
 	y *= h;
 	p[20] = ((x << 4) & 0xffff) | ((y << 20) & 0xffff0000);
-	p[28] = (((x + w - 1) << 4) & 0xffff) |
-	    (((y + h - 1) << 20) & 0xffff0000);
+	p[28] = (((x + w) << 4) & 0xffff) |
+	    (((y + h) << 20) & 0xffff0000);
 }
 
 int
%%%