Subject: kern/32082: Comment wrong in .../sys/arch/i386/i386/locore.S - basemem and extmem in wrong order
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: None <djb_netbsd@charter.net>
List: netbsd-bugs
Date: 11/15/2005 21:42:00
>Number:         32082
>Category:       kern
>Synopsis:       Comment wrong in .../sys/arch/i386/i386/locore.S - basemem and extmem in wrong order
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Nov 15 21:42:00 +0000 2005
>Originator:     Dave J. Barnes
>Release:        2.0.2, 2.1, -current
>Organization:
>Environment:
>Description:
Parameters on stack are
    (howto, [bootdev], bootinfo, esym, extmem, basemem)
                                       ^^^^^^  ^^^^^^^
- code is right, comment is wrong.

Sanity check from sys/arch/i386/stand/lib/exec.c

    boot_argv[0] = boothowto;
    boot_argv[1] = 0;
    boot_argv[2] = vtophys(bootinfo);	/* old cyl offset */
    boot_argv[3] = marks[MARK_END];
    boot_argv[4] = extmem;
    boot_argv[5] = basemem;

============================
sys/arch/i386/i386/locore.S

	.globl	start
start:	movw	$0x1234,0x472			# warm boot

	/*
	 * Load parameters from stack
	 * (howto, [bootdev], bootinfo, esym, basemem, extmem).
	 */
	movl	4(%esp),%eax
	movl	%eax,RELOC(boothowto)

>How-To-Repeat:

>Fix: