Subject: Re: port-m68k/30924: m68k copyinout_t breakage
To: None <port-m68k-maintainer@netbsd.org, gnats-admin@netbsd.org,>
From: Quentin Garnier <cube@cubidou.net>
List: netbsd-bugs
Date: 08/12/2005 10:15:04
The following reply was made to PR port-m68k/30924; it has been noted by GNATS.

From: Quentin Garnier <cube@cubidou.net>
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
Cc: christos@zoulas.com, gnats-bugs@netbsd.org
Subject: Re: port-m68k/30924: m68k copyinout_t breakage
Date: Fri, 12 Aug 2005 12:14:02 +0200

 --DOQx4ubtbYINM/to
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Fri, Aug 12, 2005 at 07:00:10PM +0900, YAMAMOTO Takashi wrote:
 [...]
 > > included from time.h.
 >=20
 > what i said was about including systm.h from type.h.
 > i think it's a bad idea because type.h is
 > more "primitive" than systm.h, IMO.
 >=20
 > from time.h, it's ...acceptable. :)
 >=20
 > > types.h looks reasonable to me.
 >=20
 > it's also acceptable to me for now.
 >=20
 > > I don't want to move timer_create1's
 > > prototype away as it would only solve the issue for that one, although
 > > it might reproduce with another header.
 >=20
 > i think sys/time.h is one of the worst headers in the respect of
 > circular dependency.
 > it has both of "primitive" types like timespec and
 > high-level prototypes like timer_create1.
 > while the latter is not needed for the most part of kernel,
 > sys/param.h includes it for the former.
 > it also propagates bogus dependencies on headers like sys/callout.h
 > throughout kernel.
 
 What about this?
 
  - put the copyin_t/copyout_t prototypes in systm.h
  - split time.h to timevar.h.  The latter would contain most if not all
    of the #ifdef _KERNEL block inside time.h
  - have timevar.h include systm.h
 
 Dropping the copyin/out_t prototypes in types.h would have the advantage
 of not caring much about time.h inherent brokenness, while putting them
 in systm.h means we might face similar trouble as for time.h with
 another header.
 
 --=20
 Quentin Garnier - cube@cubidou.net - cube@NetBSD.org
 "When I find the controls, I'll go where I like, I'll know where I want
 to be, but maybe for now I'll stay right here on a silent sea."
 KT Tunstall, Silent Sea, Eye to the Telescope, 2004.
 
 --DOQx4ubtbYINM/to
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.6 (NetBSD)
 
 iQEVAwUBQvx2atgoQloHrPnoAQKJjggAilNb8tF1a5grjMR8ROo3IhXcOyl9kk3H
 55iKfd+p/7hj7/zho1mJqv3DmFpKJkAE/vNAjQ2LJOAz+5ta8YpQByKTltUwUhLW
 C82pDWVii3ziQzpJG8MeL9/5/tEoEA+SEuDWQHqCO6ElPndSec5ZFVdl3fQej+1I
 wlyqMfdTzIT71HPpjmjBR8OK+LcK0txqpt+UN6Wia7Vh1EBMGl3LH+rc4RSD3XV8
 LNis71qCZ9i7S2FJuOltGu+fFZmysF+yr7Qc+/0A5jv2vXoa76x221ahh1mxez/m
 bNh5A3qOY0ZLUYaM5pvZI2a9KvWZV8pR6MHmC6H0ji2qFm7RCET5nw==
 =2guG
 -----END PGP SIGNATURE-----
 
 --DOQx4ubtbYINM/to--