Subject: Re: port-m68k/30924: m68k copyinout_t breakage
To: None <port-m68k-maintainer@netbsd.org, gnats-admin@netbsd.org,>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: netbsd-bugs
Date: 08/07/2005 03:57:01
The following reply was made to PR port-m68k/30924; it has been noted by GNATS.

From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
To: cube@cubidou.net
Cc: gnats-bugs@netbsd.org
Subject: Re: port-m68k/30924: m68k copyinout_t breakage
Date: Sun, 07 Aug 2005 12:56:06 +0900

 > 1. sys/param.h includes time.h
 > 2. sys/systm.h contains prototypes that use "struct clockframe"
 > 3. arch/i386/include/cpu.h does a #define clockframe intrframe
 > 
 > So, if I include systm.h (where the copyinout_t definition belongs)
 > in types.h, I get prototypes using a forward declaration for "struct
 > clockframe", but when I get to the definitions in kern/kern_clock.c, the
 > clockframe part has been #define'd to something else, thus compilation
 > breaks.
 
 ok, i see.
 i don't think including systm.h in types.h is a good idea, tho.
 
 > > i think that it's really your area because you are adding
 > > another complexity to the crappiness.
 > 
 > Does the definition of copyinout_t looks complex to you?  Come on.
 
 you introduced more header dependencies, didn't you?
 
 YAMAMOTO Takashi