Subject: Re: port-m68k/30924: m68k copyinout_t breakage
To: None <port-m68k-maintainer@netbsd.org, gnats-admin@netbsd.org,>
From: Quentin Garnier <cube@cubidou.net>
List: netbsd-bugs
Date: 08/06/2005 14:09:03
The following reply was made to PR port-m68k/30924; it has been noted by GNATS.

From: Quentin Garnier <cube@cubidou.net>
To: gnats-bugs@netbsd.org
Cc: port-m68k-maintainer@netbsd.org, gnats-admin@netbsd.org,
	netbsd-bugs@netbsd.org
Subject: Re: port-m68k/30924: m68k copyinout_t breakage
Date: Sat, 6 Aug 2005 16:07:56 +0200

 --f2QGlHpHGjS2mn6Y
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Sat, Aug 06, 2005 at 01:16:00PM +0000, yamt@mwd.biglobe.ne.jp wrote:
 > >Number:         30924
 > >Category:       port-m68k
 > >Synopsis:       m68k copyinout_t breakage
 > >Confidential:   no
 > >Severity:       serious
 > >Priority:       medium
 > >Responsible:    port-m68k-maintainer
 > >State:          open
 > >Class:          sw-bug
 > >Submitter-Id:   net
 > >Arrival-Date:   Sat Aug 06 13:16:00 +0000 2005
 > >Originator:     YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
 > >Release:        NetBSD 3.99.7
 > >Organization:
 >=20
 > >Environment:
 > =09
 > =09
 > >Description:
 > 	some of m68k ports seem broken due to copyinout_t changes.
 >=20
 >     compile  GENERIC/fpu_add.o
 > In file included from /exports/nbsd/src/sys/arch/m68k/fpe/fpu_emulate.h:3=
 9,
 >                  from /exports/nbsd/src/sys/arch/m68k/fpe/fpu_add.c:58:
 > /exports/nbsd/src/sys/sys/signalvar.h:181: error: parse error before "cop=
 yinout_t"
 > /exports/nbsd/src/sys/sys/signalvar.h:182: warning: function declaration =
 isn't a prototype
 > *** [fpu_add.o] Error code 1
 > 1 error
 >=20
 > >How-To-Repeat:
 > 	eg. build x68k GENERIC kernel.
 > >Fix:
 > 	- reconsider if copyinout_t is a good idea or not.
 
 That's irrelevant.
 
 > 	- restructure headers?
 
 I have two options:
 
  - put copyinout_t in its own header, and include it when needed
  - put copyinout_t in types.h
 
 Tell me which one you prefer.
 
 --=20
 Quentin Garnier - cube@cubidou.net - cube@NetBSD.org
 "When I find the controls, I'll go where I like, I'll know where I want
 to be, but maybe for now I'll stay right here on a silent sea."
 KT Tunstall, Silent Sea, Eye to the Telescope, 2004.
 
 --f2QGlHpHGjS2mn6Y
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.6 (NetBSD)
 
 iQEVAwUBQvTEPNgoQloHrPnoAQLvqQf+KwfwdjXcqo6EhwSW8N+cLpto2hLimSzL
 7eAApnN9pD10E7w1uGD+3cx1APJ/ixuAm6NcCO/JlGqFkXjzIC42yVnyTV/QSiEw
 8pUQAkhi9B99MbQHxzpSpUTxoITLL1ypqmMzGjgZHWEyXf9ZBnZ4zZCKNfR1gEu2
 T1PSP6FbWUkNDVDBsfBxHn9QWEGZALjo5GRw9tFuBxRZL7vUTfVi2+GWi15X5vm4
 QxL6/gamQMWxzX2Y2nYwUg64N3ZAzO9XK5P+3pftcLZkN6E/UTyYxwxiYGGlmBnA
 CNY+YkhG0DX8BoeOwfB0cQMd4caVplcIeeuaaku91p3AyPbDdMRkhQ==
 =Tugc
 -----END PGP SIGNATURE-----
 
 --f2QGlHpHGjS2mn6Y--