Subject: kern/30248: ums(4) limits number of available buttons to 7
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: None <svs+pr@grep.ru>
List: netbsd-bugs
Date: 05/16/2005 19:19:01
>Number:         30248
>Category:       kern
>Synopsis:       ums(4) limits number of available buttons to 7
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 16 19:19:01 +0000 2005
>Originator:     Sergey Svishchev
>Release:        3.99.1
>Organization:
>Environment:
>Description:
The Logitech MX1000 cordless mouse has 10 buttons and a wheel; however, the code in ums.c assumes a maximum of 7 buttons.  Not fair :)
>How-To-Repeat:

>Fix:
--- src/sys/dev/usb/ums.c.orig	2003-03-11 19:44:00.000000000 +0300
+++ src/sys/dev/usb/ums.c	2004-12-24 00:02:28.000000000 +0300
@@ -88,7 +88,7 @@
 #define PS2MBUTMASK	x04
 #define PS2BUTMASK 0x0f
 
-#define MAX_BUTTONS	7	/* must not exceed size of sc_buttons */
+#define MAX_BUTTONS	31	/* must not exceed size of sc_buttons */
 
 struct ums_softc {
 	struct uhidev sc_hdev;