Subject: kern/25217: undefined variable in bsd.kmod.mk, malformed conditional
To: None <gnats-bugs@gnats.NetBSD.org>
From: None <ccatrian@eml.cc>
List: netbsd-bugs
Date: 04/18/2004 04:05:48
>Number:         25217
>Category:       kern
>Synopsis:       undefined variable in bsd.kmod.mk, malformed conditional
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 18 04:07:00 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator:     Cesar Catrian C.
>Release:        NetBSD 2.0_BETA
>Organization:
	
>Environment:
	
	
System: NetBSD core.cjc.cl 2.0_BETA NetBSD 2.0_BETA (SAT) #4: Mon Apr 12 21:11:26 CLT 2004 cetrox@core.cjc.cl:/home/cetrox/src/src/sys/arch/i386/compile/obj/SAT i386
Architecture: i386
Machine: i386
>Description:
A problem running /usr/bin/make including /usr/share/mk/bsd.kmod.mk.
Malformed conditional, when MKUPDATE not defined
>How-To-Repeat:
Make at pkgsrc/emulators/vmware-module, ie
>Fix:
Please review.

--- share/mk/bsd.kmod.mk.orig   2004-04-17 23:34:12.000000000 -0400
+++ share/mk/bsd.kmod.mk        2004-04-17 23:59:20.000000000 -0400
@@ -111,7 +111,7 @@
 .if !target(kmodinstall)
 _PROG:=                ${DESTDIR}${KMODDIR}/${PROG}            # installed path
 
-.if ${MKUPDATE} == "no"
+.if !defined(MKUPDATE) || ${MKUPDATE} == "no"
 ${_PROG}! ${PROG}                                      # install rule
 .if !defined(BUILD) && !make(all) && !make(${PROG})
 ${_PROG}!      .MADE                                   # no build at install
>Release-Note:
>Audit-Trail:
>Unformatted: