Subject: xsrc/25199: xdm built from src/x11 does not use mkstemp
To: None <gnats-bugs@gnats.NetBSD.org>
From: None <njoly@pasteur.fr>
List: netbsd-bugs
Date: 04/16/2004 14:44:06
>Number:         25199
>Category:       xsrc
>Synopsis:       xdm built from src/x11 does not use mkstemp
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    xsrc-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 16 12:45:00 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator:     Nicolas Joly
>Release:        NetBSD 2.0C (-current 20040416)
>Organization:
	Institut Pasteur
>Environment:
System: NetBSD lanfeust.sis.pasteur.fr 2.0C NetBSD 2.0C (LANFEUST) #3: Fri Apr 16 10:45:57 CEST 2004 njoly@lanfeust.sis.pasteur.fr:/local/src/NetBSD/obj/amd64/sys/arch/amd64/compile/LANFEUST amd64
Architecture: x86_64
Machine: amd64
>Description:
xdm(1) build with src/x11 framework does not use `mkstemp()' function, like
xsrc build.

This was noticed, while trying to login, via xdm, when there is no .Xauthority
file. Without mkstemp() support in xdm/auth.c, the 1st login fails; but the 
2nd pass ... But works fine for the 1st login, with mkstemp() enabled.
>How-To-Repeat:
>Fix:

Index: x11/bin/xdm/Makefile
===================================================================
RCS file: /cvsroot/src/x11/bin/xdm/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- x11/bin/xdm/Makefile	19 Jan 2004 00:30:01 -0000	1.5
+++ x11/bin/xdm/Makefile	16 Apr 2004 12:28:27 -0000
@@ -9,7 +9,7 @@
 		streams.c util.c xdmauth.c xdmcp.c \
 		Login.c greet.c verify.c
 
-CPPFLAGS.auth.c=	-DBSD44SOCKETS
+CPPFLAGS.auth.c=	-DBSD44SOCKETS -DHAS_MKSTEMP
 CPPFLAGS.genauth.c=	-DARC4_RANDOM
 CPPFLAGS.socket.c=	-DBSD44SOCKETS
 CPPFLAGS.xdmcp.c=	-DBSD44SOCKETS
>Release-Note:
>Audit-Trail:
>Unformatted: