Subject: pkg/23956: ...pkgsrc/archivers/arj has build problems on NetBSD/amd64
To: None <gnats-bugs@gnats.netbsd.org>
From: None <rkr@olib.org>
List: netbsd-bugs
Date: 01/02/2004 21:42:50
>Number:         23956
>Category:       pkg
>Synopsis:       ...pkgsrc/archivers/arj has build problems on NetBSD/amd64
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 03 03:43:00 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator:     
>Release:        NetBSD 1.6ZG
>Organization:
  "I probably don't know what I'm talking about."  http://www.olib.org/~rkr/
>Environment:
System: NetBSD socrates 1.6ZG NetBSD 1.6ZG (socrates) #1: Wed Dec 31 15:24:34 CST 2003 root@socrates:/usr/netbsd/current/src/sys/arch/amd64/compile/obj.amd64/socrates amd64
Architecture: x86_64
Machine: amd64
>Description:
	The "arj" package does not build for me out of pkgsrc.  It has
	numerous warnings and at least one show-stopping error caused by
	a missing "-fPIC" for some code.

	Patches are included.
>How-To-Repeat:
	Try to build "arj" from pkgsrc on my AMD64 box?  (^&

	"make >& log", "view log", search for "arning" and "rror".
>Fix:
	The below patches remove the errors and all warnings.  Some
	warnings are nuissances (main() returns an int, not void;
	the generated "c_defs.h" needs a trailing newline).  Others
	are more serious (pass the address of a 64-bit integer to
	something looking for a {time_t *}; casting 64-bit pointers
	to 32-bit integers).

	Especially a second pair of eyes to check the changes
	from "(unsigned int)ptr1 > (unsigned int)ptr2" to
	"(ptr1 - ptr2) > 0" would be appreciated.  The
	code is making me cross-eyed, so I might have changed
	> for < (or vice versa) in some places.

	I think that the below are all necessary patches to eliminate
	all warnings.  (I know I have eliminated the warnings; I might
	have forgot to make a ".orig" file for some of the patched
	files.)  Because there are so many modifications, I am including
	the patches in a uuencoded .tar.gz archive.  At least one patch
	is a modification to an existing patchfile.  Because I generated
	the list automatically, the simplest thing was to include all
	patches, including pre-existing changes, so this *should*
	replace all arj patchfiles.

	Two of the patches have some XXX comments; one is in a
	makefile.in (the change may be port-sensitive), and another
	is in a regular C file (the change questions a previous
	comment and explains why the original code was wrong).

	Lastly, the format of the patch: ./arj-patches/* is a
	tree that mirrors the arj source tree.  (Is there a nice
	tool for generating the patch-?? sets?  I used find/sed/awk/sh
	to generate the patches in a one-off command.)  The C patches
	are in, e.g., "arj.c" for the arj.c file.  There is a further
	sub-dir for some of the GNU autoconfig stuff.


begin 644 arj-patches.tar.gz
M'XL("%PU]C\"`V%R:BUP871C:&5S+G1A<@#M7/]WVC@2[Z^;OT*;]KH0,+'-
MMX0TW5)"M^PED`>DV[TTS\^Q3>+&V)QE\N5Z_=]O1I*-L4V2]K7NW2U^>1&6
M1M+HVV=&HY%U_Z,TTP/CTJ)/OM<CRS6Y6:]#R)YDR'\WF\UZK2I7:U6(5U2Y
MVGQ2?Y+#,Z>![A/RQ/>\X#ZZFTO+<I[\WSWZ8ORW+??:]CVW8GSK\5=DN5&K
MK1I_I::HX?BKM0;&*]4FC+^\'O_O_DB21*)Q_TF%I2K)BB2K1)5;]7JKJE:B
M-4HDN2'+&Z52:9&CXOGV!693);DJJ4VB[+1DM57=265[]8I(]6JY24KL_ZM7
M&X0\M2?$M":V:YD%QW;GMT6(A%C7<.:F15[0.[IM>T;@5"Y?+J<PZNT)Q02)
M/+6<6$F:]L:WK->C`TTKDG__.Q;?MP(>O5&Z)T^:AYGNZ],4#Y@R]>9NP%.@
M0&JQ9JI-5<&&BI`UE<SH_LPJ*7OP^S.YN;0=J[`ULW[>_^6#_$MQ3W3&Z,U[
M[;#[KGNXO]\>_@XM(S3PC=E=P;1H4":;VW/J;\^N+K;/;7<;ENXFY"QE$L4(
MB&CK<N'P]@[Y6LY;P4QT<GM];\:PE;NBE;O1@&;3_SY<7=-'/UY5.![#+N0L
M/M`!OO5@%T0DX?@`'TAS*I^QGN<)KFE/-I[\)9\X_@>>J=]]<_1_$/_EAEI+
MX7]-KJ[Q/R?\%^,>1W^EUE)W5Z&_H(^P/YZIV5)JF=BO-!$LV'^$B@VRO46.
M=-LEOC</8,V3K6V(E6PW(%.(+N`/W;\PRL2XA`':VH*7:P#N:\\V[Z4@GV!-
MLQA3#RR-VA>G-?FL3"8:OI^":GFV%U)`U9JK3ZW33N?M4?O]<7O\%A*1W>9.
MN4Y*[#_'[\G,APHG!0`:2Y\"QK`"SN>V8_*"S_8_;/Z-?MC<^^!NEJ.Z&?20
MB>%XU!)Y6=1GP#;?"N:^2V0$,.O6#@HR)GW>^%'K?THO`#/-W/4_M=9,ZW^*
MO%[_.:W_:-P3B[FJM*J-3`2(<F1A0!4TQVP,J.[6$`1X$*%`VS4)]<B-1<ZM
M"]NM5"K?`0NH-_<-Z_1-[[#;;Q]U-5CM9WLD_@`G0VO$R,@$U#/$!<8(+P!F
MR845:/;J(J"`2D?"K,3PW`#8LMT+,O.`-\NG6!33@7<;B"P\8-`RF<T#6MAD
ML&%C]N+>4IR;$3?)B+OD<1L1W$2%\5=W^76R_!K+#9IP`498.Y]/)I8/<3&H
M(O<_K!-GGA\0UR.6[WL^MGL!;U^5/6=(_,OJ?_#[.VA_#^-_HY'>_\LU=8W_
M.>$_&_<DB#=:-243^QEU)NXW6W(S$_>;,ML/\^"KM#^$\].S>R$_)&&8CXG&
MU-P3/VVJZ::IL1AD:%=1R@J@L`BYA@<P@_]A-S@+_/T`_C'=C03L=3K36`QL
M2<7VO<`I)4POOI31J!`ES5W0_6`CB[47D>#%<A3/RDP-C%^.?>W1$$3/;0M:
M9!E79`+PYUT##,Y=`L.DUK?EG6WH<P5["_D([0B,0[:???X\Q1;G*Y/T2[CD
M_5`J\1X`097=?I;P1>6*YN-P[<]TGUHX3`[,B0+F+&-\450:;\3/#[0WD_;+
M&ARUF"QFQV>^F5&;NRC%1<CF#XR3Z^W+;,I-"DQX4>P50K@D*QQI;P8G_0.M
MKW6'P\%P5.;Q-"Y@68QC75M.M"E81'V/W4$"_[69[QG?6@@\@/_51C.E_^.!
MP1K_\\-_,>Y+B%X'";!J`[#(DI8$]98,PJ.1*0E4564V0Q9PV-41D73?N+2O
M+;89+\$V&=3O0CRN6'+8,MQBU*'ECCCV%%<<@`-@98$#M3V%C3>L6T=2]@B+
MD\*XXDN@9JM:DAA,K,J5PHF7^XDX0;\H+4(R6/P"9;=8V26E*`!EJR!)R']Q
MOP",`S;\BFAS*DGP=M;:XA('>ZDF[S#Q)$(AGK;,>-LIOIA"2+$4>H,](000
M@T2D*;Y@R)PEE\PT`%(!?ZPI`D'-2&3P=I@+.8!@GZPI+0'NJ6?19R"BZ8T-
M0,0*#+M,=W7G[E^6!L*=Q\<%,.-L(0>6&(E+XV6Z1[.V:*E`?X[]]9TZ.\5@
M`0X-V[0@>E,27%H`VKH!F@D[&2#>!"U!.B3HH)!X<\>$32ZA^L1R[LB-;P>!
MY9+`PXR\;RT*ZI`>V)Y+KCUG/@TUHXA%QX--)>Y$(9GMU)93;-?PK:D%[=@H
MQ9N5G87I1HL<;#26RYM!GKUX+%>[/E++T%`WN;1TH5,U9-8O/&!3%HH%16V?
MMT.#26X'TB2P'*>@>\(4)F'Y4@&K*B9*E3:B;2%/1V/=^5U@44%OS+SPIW7+
M&H=='<MV='(X[KT;')[`9GW8'76'[[H2HT-VO,F$6L%"]!:6.[(X!163-Z!,
M$DF+'F-G#ZG\.(L>FQTG%IM"QY8/:#2EY%KW;6].N0Y(80K##)G.G<`6\X'-
M)YN2F6Y<09$P>6:^9=HXYUR.L=7&;EFI`<J*'P(_R%9`E]`SU'1IJ.KR=!KJ
MN0DUEW(%Z_EST!<""Z;[BU&W/>R\U4;C(1I#V)++U'_I*DWKGK(B;`CU.)J`
M(<YMJ)#&]5$:5TC3^BA]E#I.+90_B/&G(8^ETEG865*2LPA>,IG()OTBMF+M
MC;31;Z`,)O2_X&YFT9SU/U5II,Y_:HJZUO]RU/_$N"\Y`"@M!?2XG57ZG\B2
MI?_5:BU%SCX%4ID%F`>1):#CN0#Z`24Z.>GWWA/4KF!8IC,A&LG!8$1H<.>$
MTA`2`]M(B*J`:G/7OE5-CQ:8?A9`%*R_!XF3*4(0PM*?`ZH&4[)%@RDL.]Z"
M*@=7#'D3TD)S+K:!*%T1*P0WOK&W9.I\__X]&8!&8'@FZ@2VV2*;'=W])2!S
M"A&\0-&4(KFT?&NS'&W]LVRG6.#Y/""7NDD^+;'T&9BA`4C5,D*1<4EN=!`M
M/C+[4($]@$(+[;$@L"FH):X7X+`@BUNP!9A9_A;YQ)G\7&%BYH$"4YQ1T(D,
M'0NTT?QS!QOCRD6EC)I2H_:(`L_M@)8YQ$:<+)2MJLH(@+4_+)Q,[L,%SG1*
MR:?GOO$96^IXANY@L85B&62L24P/Q^C*]6Y`NK#Y^5"!4]!W).+YQ($^#"1L
MOCVQ#1TF"/(&RXFQ%O+Z,(=,GXPQ!C684*)%*RLLZ\P*OSQ+EZ9CHH[[IR$_
M%N&KY5_TTIX$PH'%-:T)&?]#>]=F'A^,@J6;2EG\4/?6QOS_4OO_1\]VO\<!
MP(/^'XWT^:]:5=;R/R?YS\<](</KS9:\FRG[.7F6W*\W6G4U4^XS3['=2.8+
MD2Q<*/"4\?1X..AHKP\'G;]KH]X_NNBC\<U.@/'(EFR]`PS:>J?NI<3UN;"Z
M,)</^"]V3*&_F'#\V#RA^H75(K\/>GWR@A\'OR0O<+OJZ'<ORQ_\#^[F8O-)
M-D4(LJR,8D2?S4"?)V^[A\>5]O!WC(*@TGW?A630I7C!(BHB8Z4N'\%^4R-P
M?/W#?CKX`?9?N9[V_Z@IM;7_1U[K?S'NR?6\VY*S[;^++)DXL-.J99\$*CL[
M3/]G00Y^8'SE<V-3J)+/9AJNM_WC8ZT_Z'?WA&&:'>CP0!A,?&/_>#`:,V3J
M#@^U/]K#?J__&W??2CMU14L4%*OP\,8W\G?I^NKU3R>W-)B?Y^W_)=?E>MK_
MJ[[V_\]K_4?CGE[^&<L8EW^4(W/U[[:4:O;JKY85&;?.Y=UOM?C%.E\X9Z(1
MM4R.M-&;]Z/QR6OM=;O?[PZ98],]1(<GP]>:\B@J]3M*XQ_N_P,#^^UW``_Y
M_]1KC=3ZKZ--<+W^\[+_L7%/6O_DEEQ;9?UC&=*KO\%N_V3O`12YSBUG/.1"
M-G&@*XXD]/!$@J4:4Q,/`&G&H80>L[)G'3WH]QK5EPX8].3Y@IY]O*#?>[J@
M/^IP8=G/15\<;,:921XIZ%DG"OK*`P7]H?,$/7V<P._UU/BUGEJNSEIS'\<X
M=1'J9717B6W1:@J(CA(/^`3Z++2Q%;DD$D(UQ#`M;G32Z71'(W9KB.EHB838
M9:&ES%CXJOR)M&+L6A$[X/M?PO^/?L[[/Z514]/[/V5]_I,O_N.X)[&\V5(:
M]T@`S)(I`]!\E"D#&K+"9(`(_\HR`%JCP0XS[N'RWR4(&KO,5XL'.>S519J&
MV^>$PXDM+F6I,O,C9@&;.VB#L"C5A*]8H;CD?OGS?I;_)?>^C&OQA1O=Q\L:
MZ*_Y:WAEE0$ZHVTM1<7PG\'_UV2..WYT?$L/+#S[#/1SQV)>OZ9E>*;-#^?R
MPW]V63;_^Y]*+6/_7UWK_[GAOQCWQ.W_6JTERYG@+^BSD%_%P_\5)_]UF1_]
MU^7\\,1PKP%/RFRE:GC.SEPG8Z</K"V:=9MQ!52IR[MEI0HLXX]0W\2+4<)$
M<*1U_CC0CDY&8^UU5^L>'8__#/$'KPN8-LB2_LGA(7>HE,+ST?Y`._K[P1CH
M$>E#RNF5&5C366%S&V+859SW[-DL[H6'O@?LW!FX-B5LRJ_LE#BZUAX6!*&K
M3PNL8H;IP`[>[=*@!ML/.1,.EB$R=MK],7+5&Y;#@A`@0QV6B051T2?1.;M-
MY@%?WZV&%E-F%'5L"CWM6+H[GS$7X<)S'H?CQ>^7K22Q;@UG3FW/70)G>F7/
M8.SF;H`(&XUDBWTC(!N2'YVEN/<7OUVVC/\7,`I6WOH_I%4S]/_U^4]^^!^.
M>U($`*`K*T1`F"4E!3`?Z/_*BJ\`J/PS`#GJE!>.=ZX[&K"\ESH18@8/A2$9
M#SC(A[`X[/ZFO6E#CH,0V!F2&H'_4BFFI`%2CP?C]N&H3$*Z.))!>F\T[F:K
MD5F).:!38O]OVG26__F/*F?<_U_?_\QQ_\_'/;W\JRO=/WF.5:M_=\7I+_?^
MW*GEM/HG!4S:WU>+D>*BRO5R`U8["_AJIY?>C8::CGNA4<-W^2XRU*M8*FHI
M4=KJ+W>0_SE58LG_0S>N](L?(?_3]C]Y[?^1G_]'-.[)E=Q<M05<9,E$`#0!
M9M__VV7^'SS(`0'"/5=G<'34'79Z[4-<THQNHD]MYTX+](O3L_U-_$R8<`-K
MRLP/C`4,(*B0\.*\IDPV_T8WR3%AF41(7D%<F;!S#>6L3&97%YI/9PQ)Z!VH
M2M,P>Y%;M^#G56%!]:.^!A1?_Q?N_+O4\67?_ZRS[W\VJNKZ^Y\YXS^,_[;A
MN1/[8NY;%=O-"_^;:?_?^MK_-S_\3XY[\IMN<JN:[0>0S)CY-=!JJ[;"'X!]
M%$0)OPG2[FC'P\%O6J\_@BW48<%J;7M4U6<SV)C,`P_KV<9+++KC2/2RB*+#
M=!V\.\3JYW=FV9<Z+?S>TH8$!78&_3>]W[2WW?9!=U@P-!`%M'+9XCQ7+H%E
MD"0INDIE.YLTK)+?S$1#/5[:,'37<VU#=P30$[RPSMK3:?<'_5ZG?:B]'8S&
MHM'U,OI`L$`T>W3R>C0N'/S9UPY[KT?%6-SA`5Z([!UCU=B>P<GX^&1<F.I7
M%FXP*S``K>@E;(P@@E:LIENY_F-4>>E_U:J2LO_4967]_<<\UW]LW!-N0/"W
MXB)`(E]\]4/^':+@QR!;ZO+JKX??!%*9+V!D".*FV<[@>$SVB73`7LFS`D84
M-Q:FDQ@!CUG00(:#WNAX02(B(@KI*9K114#XQX"W]:G9J('R]<^Y[5MX@]^F
M9%.:'/<ZFQ5"1I?L&ID=X$TRP`+31IC1G5^CPJ"2SO#/XW%8K:B,L")@/68G
M;Y#0J3#B5D0L*#;(4W((6B+HV5PQ5:ME50'-5)4QQ$Y[BE0"%%L;TD_&#+)C
M/Q[TAD6TYSR[):]F/HS0[2O\'BYP_9/D3X$Y$O]*\+-;3'!<(E$>SVZ6+5)3
MQ%%%O&UA;89_-PN>F8LJ'?M\.UDGQBUH,RM>)LG.QEG@LX;5STYR$NW=SFJP
M(%S9Y+"@=(:HV6R>A:U&2\ACZHU([^ML45A6IK#%8B6(1G,[[./:'=+>T_2H
MN*QLI<P)EB@#J+*G6.D+9ECI@1F6F"R).A-SI?15,ZRT<H8]W.!PQI2^<(:5
M[IUAC^IH,5M*7S'#2@_,L,>T.S97OF:&$89I3\DQLR^@!T3A1J>MR-X`V9X5
M7K='7>!-ZQ07+\7B^EKIM]O_,7TW-_M?34GY?]>:U;7]/__]'QOWY/9/;=5W
M'MC^L7R9WP-75WT)#*]9EL*[ED_GS$KWMOVNJXVZX^-A;S#LC?],)(R''5CL
MG:/C5/S)\1!DVG+<X1_#C5)&W`?2]XAKW:`MCN@!NAOB9YI0B5U#R/I9/^MG
@_:R?];-^UL_Z63_K9_VLG_6S?OX/G_\`T`]XBP!X``#B
`
end
>Release-Note:
>Audit-Trail:
>Unformatted: