Subject: Re: install/23548: fdisk in sysinst, off by one.
To: None <netbsd-bugs@netbsd.org>
From: David Laight <david@l8s.co.uk>
List: netbsd-bugs
Date: 11/23/2003 18:01:11
> >Description:
> 	When you configure multiple fdisk partitions on i386 sysinst code does:
> 	1. create a partition with 1 cylinder greater than asked.
> 	2. second partition, starts at the ending cylinder of the first
> 	   partition.

What is the actual problem here?

The menu looks like:

 The Current MBR partition table is shown below.
 Flgs: a => Active partition, d => bootselect default, I => Install here.
 Select the partition you wish to change:

    Total disk size 4160 cyl.
               +----------------------------------------------------+
    Start(cyl) | a:       kind: NetBSD                              |
    ---------- | b:      start: 3700 cyl                            |
 a:          0 |>c:       size: 460 cyl                             |
 b:       3300 | d:        end: 4160 cyl                            |
>c:            | e:     active: No                                  |
 d:            | f:    install: No                                  |
 e: Change inpu| g:   bootmenu:                                     |
 x: Partition t| h:    default: No                                  |
               | i: Change input units (sectors/cylinders/MB)       |
               | x: Partition OK                                    |
               +----------------------------------------------------+

The only possible problem is that the displayed 'end' value is actually
the the next unused sector, and not the last one used by this partition.
So 'end == start + size', rather than 'end = start + size - input-unit'.
Note that the user is only allowed to change the 'size', the 'end' is
displayed for information.

	David

-- 
David Laight: david@l8s.co.uk