>Number:         23461
>Category:       pkg
>Synopsis:       security/john overwrites compiler flags
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 16 22:09:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Christian Biere <christianbiere@gmx.de>
>Release:        NetBSD 1.6ZE
>Organization:
>Environment:
System: NetBSD cyclonus 1.6ZE NetBSD 1.6ZE (STARSCREAM) #5: Sat Nov 15 01:35:55 CET 2003 bin@cyclonus:/usr/build/sys/arch/i386/compile/STARSCREAM i386
Architecture: i386
Machine: i386
>Description:

The package security/john uses a very unflexible Makefile and it will
not use CFLAGS etc. from /etc/mk.conf because they hardcoded in the Makefile.
For easier fine-tuning, I suggest removing these hardcoded settings.

>How-To-Repeat:
>Fix:

Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/security/john/distinfo,v
retrieving revision 1.2
diff -u -r1.2 distinfo
--- distinfo	2001/04/19 15:40:32	1.2
+++ distinfo	2003/11/16 21:58:28
@@ -2,3 +2,4 @@
 
 SHA1 (john-1.6.tar.gz) = b49d371496b8ba5e439665b83190b1e4d4640bea
 Size (john-1.6.tar.gz) = 497341 bytes
+SHA1 (patch-aa) = 5bfea91c84b982239a4bd9264228be2d47e9745d


--- Makefile	1998-12-03 01:29:50.000000000 +0100
+++ Makefile	2003-11-16 04:42:05.000000000 +0100
@@ -13,10 +13,10 @@
 SED = sed
 NULL = /dev/null
 CPPFLAGS = -E
-CFLAGS = -c -Wall -O2 -fomit-frame-pointer
+CFLAGS += -c
 ASFLAGS = -c
 LDFLAGS = -s
-OPT_NORMAL = -funroll-loops
+OPT_NORMAL =
-OPT_INLINE = -finline-functions
+OPT_INLINE =
 
 JOHN_VERSION = 1.6
>Release-Note:
>Audit-Trail:
>Unformatted: