Subject: pkg/22958: xpkgwedge.def uses InstallAppDefFiles before it is defined
To: None <gnats-bugs@gnats.netbsd.org>
From: Greg A. Woods <woods@weird.com>
List: netbsd-bugs
Date: 09/25/2003 15:11:10
>Number:         22958
>Category:       pkg
>Synopsis:       xpkgwedge.def uses InstallAppDefFiles before it is defined
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Sep 25 19:12:01 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Greg A. Woods
>Release:        2003/09/17
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
System: NetBSD
>Description:

	xpkgwedge.def uses InstallAppDefFiles but that macro isn't
	defined at the time this file is included.

	as noted in the comment above my current hack, the definition
	of InstallAppDefaultsLong should be done in a LocalRules or
	maybe LocalTmplFile

>How-To-Repeat:

>Fix:

Index: pkgtools/xpkgwedge/files/xpkgwedge.def
===================================================================
RCS file: /cvs/master/m-NetBSD/main/pkgsrc/pkgtools/xpkgwedge/files/xpkgwedge.def,v
retrieving revision 1.9
diff -c -r1.9 xpkgwedge.def
*** pkgtools/xpkgwedge/files/xpkgwedge.def	10 Sep 2003 17:31:44 -0000	1.9
--- pkgtools/xpkgwedge/files/xpkgwedge.def	19 Sep 2003 19:16:45 -0000
***************
*** 38,43 ****
--- 38,53 ----
   * and creates a link to the real X11 app-defaults directory and moves the old
   * app-defaults files into it. This is not what we want for pkgsrc.
   */
+ /*
+  * XXX NOTE: InstallAppDefFiles isn't defined at the point the
+  * host.def file is included and thus when AfterVendorCF is defined.
+  * 
+  * This part really should go in a separate file which is included by
+  * defining "LocalRules" (or maybe "LocalTmplFile") to point to it.
+  */
+ #ifndef InstallAppDefFiles
+ # define InstallAppDefFiles	YES
+ #endif
  #ifndef InstallAppDefaultsLong
  #if InstallAppDefFiles
  #define InstallAppDefaultsLong(file,class)				@@\
>Release-Note:
>Audit-Trail:
>Unformatted: